gcm::ConnectionFactoryImpl::Initialize currently uses net::NetworkChangeNotifier to receive network changes. With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b014993310e31420272eae151d67eecb41894b91 commit b014993310e31420272eae151d67eecb41894b91 Author: Robbie McElrath <rmcelrath@chromium.org> Date: Tue Sep 25 00:53:13 2018 Migrate gcm::ConnectionFactoryImpl to NetworkConnectionTracker This CL migrates ConnectionFactoryImpl from NetworkChangeNotifier to NetworkConnectionTracker, which works with the network service enabled. Bug: 883116 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I03a8004151d5750d2ba590d670ae41a3461be03f Reviewed-on: https://chromium-review.googlesource.com/1226074 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by: Dmitry Titov <dimich@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593784} [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/chrome/browser/gcm/gcm_profile_service_factory.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/chrome/browser/gcm/gcm_profile_service_unittest.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/components/gcm_driver/fake_gcm_client.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/components/gcm_driver/fake_gcm_client.h [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/components/gcm_driver/gcm_client.h [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/components/gcm_driver/gcm_client_impl.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/components/gcm_driver/gcm_client_impl.h [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/components/gcm_driver/gcm_client_impl_unittest.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/components/gcm_driver/gcm_desktop_utils.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/components/gcm_driver/gcm_desktop_utils.h [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/components/gcm_driver/gcm_driver_desktop.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/components/gcm_driver/gcm_driver_desktop.h [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/components/gcm_driver/gcm_driver_desktop_unittest.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/components/gcm_driver/gcm_profile_service.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/components/gcm_driver/gcm_profile_service.h [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/google_apis/gcm/BUILD.gn [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/google_apis/gcm/engine/connection_factory_impl.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/google_apis/gcm/engine/connection_factory_impl.h [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/google_apis/gcm/engine/connection_factory_impl_unittest.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/google_apis/gcm/tools/mcs_probe.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/ios/chrome/browser/application_context_impl.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/ios/chrome/browser/gcm/BUILD.gn [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/ios/chrome/browser/gcm/ios_chrome_gcm_profile_service_factory.cc [modify] https://crrev.com/b014993310e31420272eae151d67eecb41894b91/ios/web_view/internal/sync/web_view_gcm_profile_service_factory.mm
Comment 1 by rmcelrath@chromium.org
, Sep 13