Allow users to change background even when a theme is installed |
||||
Issue descriptionSee questions about this in https://www.reddit.com/r/chrome/comments/9cykqu/request_a_dark_theme_that_looks_like_incognito/ Can we allow users to customize the NTP background even if they have a theme installed? Also to confirm: if a user has a theme that does not set a background, do we let them customize their background?
,
Sep 12
,
Sep 24
,
Sep 25
Issue 851035 includes previous related work on this.
,
Sep 25
Synced with Yana offline. Plan of action is to allow the user to customize the background if there is no theme or if the theme has set the background to some color (and not an image)
,
Sep 25
Clarification: We may still want to show the gearhead and override the theme image with the user selected image.
,
Oct 1
Looks great!
,
Oct 1
Nice! Btw, another good theme to sanity check with is https://chrome.google.com/webstore/detail/black-red-shards/jpjlkkaalgfbbegfnjoclhfidancjpch. This theme applies to top chrome (which I think 'Unknown Space' does not.
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c2e94f782b4c855f9c9a94e7a9d3cf3d639f2b8 commit 0c2e94f782b4c855f9c9a94e7a9d3cf3d639f2b8 Author: Tanya Gupta <tgupta@chromium.org> Date: Tue Oct 09 22:55:25 2018 Modified NTP code to always show the custom background irrespective of whether the user has selected a theme Bug: 883107 Change-Id: If3debe5245af2583d7bedd613807ed863cce7863 Reviewed-on: https://chromium-review.googlesource.com/c/1255461 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#598112} [modify] https://crrev.com/0c2e94f782b4c855f9c9a94e7a9d3cf3d639f2b8/chrome/browser/resources/local_ntp/custom_backgrounds.js [modify] https://crrev.com/0c2e94f782b4c855f9c9a94e7a9d3cf3d639f2b8/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/0c2e94f782b4c855f9c9a94e7a9d3cf3d639f2b8/chrome/browser/ui/search/local_ntp_backgrounds_browsertest.cc [modify] https://crrev.com/0c2e94f782b4c855f9c9a94e7a9d3cf3d639f2b8/chrome/renderer/searchbox/searchbox_extension.cc
,
Oct 10
|
||||
►
Sign in to add a comment |
||||
Comment 1 by yyushkina@chromium.org
, Sep 11