New issue
Advanced search Search tips

Issue 883085 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Maybe support error checking when using OpenVR

Project Member Reported by bsheedy@chromium.org, Sep 11

Issue description

Some OpenVR functions such as GetUint64TrackedDeviceProperty can take an optional pointer to be filled with error information. However, we currently don't pass in a pointer when we use these, such as at https://cs.chromium.org/chromium/src/device/vr/openvr/openvr_gamepad_helper.cc?dr&q=openvr_gamep&sq=package:chromium&g=0&l=79, instead using the default value of null.

It may be beneficial to add error checking, although the way we do polling may make it completely unnecessary.
 

Sign in to add a comment