Dashboard - Replace last_alerted_revision with an alert query |
|||
Issue descriptionThis seems to only be used in 2 spots, both in find_anomalies. First is to check whether the uploaded row's revision < latest alerted revision, and if so it resets last_alerted_revision to None. This seemingly would have the effect of allowing alerts again if for whatever reason points were deleted, at least that's the comment in code. I could imagine if points are uploaded out of order, you could potentially have new alerts but seems like that would also potentially re-alert on an old jump. Other is to decide how many rows entities to fetch when looking for new anomalies. Only look back until the last alert. Think we could just switch to a query for the latest alert, or the last alert < the revision being uploaded and we'd accomplish mostly the same thing. Thoughts?
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/560652054d057e97235526081d72bcea066e8cae commit 560652054d057e97235526081d72bcea066e8cae Author: Simon <simonhatch@chromium.org> Date: Wed Sep 19 15:56:33 2018 Dashboard - Replace last_alerted_revision with query Bug: chromium:883079 Change-Id: I6085c43986595a10ae9fd446c923a4f8b8ab2c71 Reviewed-on: https://chromium-review.googlesource.com/1222646 Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> [modify] https://crrev.com/560652054d057e97235526081d72bcea066e8cae/dashboard/dashboard/models/graph_data.py [modify] https://crrev.com/560652054d057e97235526081d72bcea066e8cae/dashboard/dashboard/find_anomalies.py [modify] https://crrev.com/560652054d057e97235526081d72bcea066e8cae/dashboard/dashboard/find_anomalies_test.py
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20136a68eadb1aaeda4252b590f0bcc047c04ebe commit 20136a68eadb1aaeda4252b590f0bcc047c04ebe Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Sep 19 18:59:44 2018 Roll src/third_party/catapult c968ea0b6538..92ef0386b8b6 (15 commits) https://chromium.googlesource.com/catapult.git/+log/c968ea0b6538..92ef0386b8b6 git log c968ea0b6538..92ef0386b8b6 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 dtu@chromium.org [pinpoint] Data migration basic error handling. 2018-09-19 dtu@chromium.org [pinpoint] Basic stats page. 2018-09-19 dtu@chromium.org [pinpoint] Update fields in Jobs table. 2018-09-19 cbruni@chromium.org results2.html debounce search 2018-09-19 simonhatch@chromium.org Dashboard - Fix alert and comparison_magnitude. 2018-09-19 simonhatch@chromium.org Dashboard - Replace last_alerted_revision with query 2018-09-19 slobodan@google.com Fixing frames in animations following response. 2018-09-19 pasko@chromium.org androidStartupMetric: remove the FCP 2018-09-18 dtu@chromium.org [pinpoint] Remove unused <job-chart-icon> import. 2018-09-18 achuith@chromium.org oobe: Catch WebSocketException instead. 2018-09-18 dtu@chromium.org [pinpoint] Remove list of differences and reformat arguments list. 2018-09-18 sadrul@chromium.org rendering: Remove some redundant mean_ metrics. 2018-09-18 sadrul@chromium.org rendering: Remove discrepancy metrics. 2018-09-18 chiniforooshan@chromium.org Telemetry: Fix SF events 2018-09-18 mattm@chromium.org netlog_viewer/README.md: Re-order with user-focused sections at top. Created with: gclient setdep -r src/third_party/catapult@92ef0386b8b6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:878390, chromium:868073 , chromium:883079 ,chromium:883715, chromium:886621 , chromium:879353 , chromium:884950 , chromium:884950 , chromium:863926 TBR=sullivan@chromium.org Change-Id: I9fa8e95d9aad524c032b0bf637dfc07926ce7795 Reviewed-on: https://chromium-review.googlesource.com/1234576 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592499} [modify] https://crrev.com/20136a68eadb1aaeda4252b590f0bcc047c04ebe/DEPS
,
Sep 20
,
Sep 20
|
|||
►
Sign in to add a comment |
|||
Comment 1 Deleted