New issue
Advanced search Search tips

Issue 883072 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Mash: window resize handles

Project Member Reported by est...@chromium.org, Sep 11

Issue description

In Ash, most windows use ResizeHandleWindowTargeter create the area where a pointer or touch event can be used to resize the window. (Some use EasyResizeWindowTargeter or a derivative.) These can either be drags or double clicks for single-axis "maximize".

This works fine in Mash for the area outside the window but not for the area inside the window (1dip). That inside area is important for when a window is flush against the side of a display.

Notes:
1. only applies when window is restored, not maximized or fs

2. 1dip drag area in that case eats input events, e.g. clicks don't go to the webpage. See https://jsfiddle.net/evanstade/f053gsor/5/ -- create restored window, put cursor at rightmost pixel of window (may be easier if you first drag the right side of the window to be flush with edge of display), click. The webpage doesn't get the click.

2b. I see some inconsistency when trying the same test, but in the window frame, where hovering the rightmost pixel highlights the window caption close button, and triple clicks get through to it but not single or double.

conclusion: we should just be able to inset the client area by 1dip on left, right and bottom when restored without loss of functionality.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/779ce514e81fcacd3465d6ba2b6d5074ee0efa5b

commit 779ce514e81fcacd3465d6ba2b6d5074ee0efa5b
Author: Evan Stade <estade@chromium.org>
Date: Thu Sep 20 21:16:13 2018

Make ServerWindow responsible for interior resize handle event routing.

Bug:  883072 
Change-Id: I24380dc595a7446e463422848916b73845945861
Reviewed-on: https://chromium-review.googlesource.com/1227357
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592943}
[modify] https://crrev.com/779ce514e81fcacd3465d6ba2b6d5074ee0efa5b/services/ws/server_window.cc
[modify] https://crrev.com/779ce514e81fcacd3465d6ba2b6d5074ee0efa5b/services/ws/server_window_unittest.cc
[modify] https://crrev.com/779ce514e81fcacd3465d6ba2b6d5074ee0efa5b/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/779ce514e81fcacd3465d6ba2b6d5074ee0efa5b/ui/aura/client/aura_constants.h

Status: Fixed (was: Assigned)

Sign in to add a comment