New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 883069 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 884089


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

Smart Lock notification shows up even before user has finished Better together opt-in

Project Member Reported by shibasheikh@chromium.org, Sep 11

Issue description

When the user is in the setup flow and is about to finish setup, the smartlock setup notification pops up even before the user has clicked on 'Done'. It shouldn't. 
 
Screenshot 2018-08-28 at 3.18.55 PM.png
2.0 MB View Download
Labels: -Pri-3 Pri-1
Cc: jlklein@chromium.org jhawkins@chromium.org hansberry@chromium.org lesliewatkins@chromium.org
Labels: -Restrict-View-Google -Pri-1 M-71 OS-Chrome Pri-2
Owner: ----
Status: Available (was: Untriaged)
Copying my comments from  issue 870123 :

To accomplish this task, you'll need to make a modification to the dialog class at [1]. Currently, that class only has a static Show() function, but it does not have a way to tell clients whether the dialog is showing. You'll need to add that functionality as well as adding some sort of observer pattern to be notified when the dialog has been closed.

[1] https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_dialog.h
Owner: hansberry@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Blockedon: 884089
Owner: ----
Status: Available (was: Started)
Let's hold off on implementing this until we figure out how we will fix issue 884089. If we end up no longer using WebDialogUI, we would have to change how this fix is implemented.
Components: -UI>ProximityAuth UI>Multidevice
Owner: hansberry@chromium.org
Ryan had mentioned that he wanted to take this on and had a clear picture of how to do so. Assigning it to him for now once his P1s are closed out.
Status: Started (was: Available)
Issue 892699 has been merged into this issue.
Status: Fixed (was: Started)

Sign in to add a comment