skylab_suite is adding unsatisfiable fake tags in chrome-pfq |
|||
Issue descriptionExample failed build: https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8935723023429833648 The tests fail with returned NO_RESOURCE because label-tag is not a valid bot tag. I had commented on this at https://bugs.chromium.org/p/chromium/issues/detail?id=873886#c8 This should not have been landed as such. P0 -- blocks PFQ
,
Sep 11
Uploaded https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1220608 to fix the problem in skylab_suite. But that'll will need a push to prod. To stop the bleeding, I'll report fake dimensions for all bots for the non-existent "label-tag" dimension. We can revert that hack once the change has made it to prod. I went through all the tests failed with NO_RESOURCE. The only values for label-tag were: ["cts_abi_x86", "arc"] Not that there was one test that failed for real due to chrome crashes: https://stainless.corp.google.com/browse/chromeos-autotest-results/swarming-3fdf755090369911/ This bug does not address that failure.
,
Sep 11
Hack for staging bots: https://chrome-internal-review.googlesource.com/c/infradata/config/+/677499 I'll land that, ensure go/chromeos-skylab-staging-bots look sane, then land the prod hack: https://chrome-internal-review.googlesource.com/c/infradata/config/+/677500
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5db8f8b5fddeb0c2159c68fd18b6330fffefe7fb commit 5db8f8b5fddeb0c2159c68fd18b6330fffefe7fb Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Sep 11 22:29:04 2018 skylab_suite: Don't add unsatisfiable task dependencies BUG= chromium:883066 TEST=None Change-Id: Id9cf1ffb10aac31b31b93cea32bfd4653bf9046f Reviewed-on: https://chromium-review.googlesource.com/1220608 Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/5db8f8b5fddeb0c2159c68fd18b6330fffefe7fb/venv/skylab_suite/suite_runner.py
,
Sep 11
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/edc5b8b0dc92ff8cc7bda4bedd3f695d9842cf68 commit edc5b8b0dc92ff8cc7bda4bedd3f695d9842cf68 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Sep 11 22:29:32 2018
,
Sep 11
staging bots are now reporting the hacked in dependencies: http://shortn/_YdpZvfBnhY And the bots are looking sane otherwise. Landing the prod hack now.
,
Sep 11
go/chromeos-skylab-bots shows that prod bots are picking up the fake dimensions. Lowering to P1 to track pushing of the fix in #4 to prod and removal of hacks landed in #3
,
Sep 11
Sanity check: The second slice (one that provisions DUTs) for one of the tasks that returned NO_RESOURCE earlier now shows that 7 bots could run that task: https://chrome-swarming.appspot.com/task?id=3fdf7555894f1e10&refresh=10
,
Sep 12
Sanity check: reef-chrome-pfq is still failing, but not due to NO_RESOURCE.
,
Sep 14
Fix pushed to prod, a recent task did not include label-tag in dependencies. https://chrome-swarming.appspot.com/task?id=3ff155adf81e3210&refresh=10&request_detail=true Time to pull out the hacks to the bot_config
,
Sep 14
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/7c7a9636bae32763bc827188c3909435e7a780a8 commit 7c7a9636bae32763bc827188c3909435e7a780a8 Author: Prathmesh Prabhu <pprabhu@google.com> Date: Fri Sep 14 20:31:54 2018
,
Sep 14
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/27d79bd51c384f2022a3bb564d41aedbd40d5e8d commit 27d79bd51c384f2022a3bb564d41aedbd40d5e8d Author: Prathmesh Prabhu <pprabhu@google.com> Date: Fri Sep 14 20:32:24 2018
,
Sep 14
|
|||
►
Sign in to add a comment |
|||
Comment 1 by pprabhu@chromium.org
, Sep 11