New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 12 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature


Sign in to add a comment
link

Issue 883049: WebUI: Implement dark UI theme

Reported by vitaly.z...@gmail.com, Sep 11

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36

Steps to reproduce the problem:
Open History at night.

What is the expected behavior?
Dark screen.

What went wrong?
I feel pain in my eyes.

Did this work before? No 

Chrome version: 69.0.3497.81  Channel: n/a
OS Version: OS X 10.13.6
Flash Version:
 
IMG_20180912_001308.jpg
834 KB View Download

Comment 1 by lgrey@chromium.org, Sep 11

Cc: groby@chromium.org
Components: -UI UI>Browser>WebUI
Status: Available (was: Unconfirmed)
I guess this would be the WebUI version of Issue 850098, so I won't dupe it. groby@ do you know who I could coordinate with on the WebUI team?

Comment 2 by dpa...@chromium.org, Sep 11

Cc: bettes@chromium.org namratakannan@chromium.org

Comment 3 by groby@google.com, Sep 11

Clearly, dpapad wears a buzzer hotwired to WebUI bugs. (And he's the contact to coordinate with)

Comment 4 by dpa...@chromium.org, Oct 15

Labels: -Type-Bug Type-Feature
Summary: WebUI: Implement dark UI theme (was: Need dark UI for History, Bookmarks, Extensions views)
FYI, we have some initial mocks for WebUI dark mode from UX and soon will have an exact spec as well.

I am going to mark this as a Feature request for now, and will share any updates on this bug.

Comment 5 by dpa...@chromium.org, Nov 7

Cc: markchang@chromium.org
 Issue 900639  has been merged into this issue.

Comment 6 by dpa...@chromium.org, Nov 7

Cc: -markchang@chromium.org
Owner: markchang@chromium.org
Assigning to markchang@ for now, since the deduplicated bug was already assigned.

Comment 7 by dbeam@chromium.org, Nov 27

Cc: markchang@chromium.org
Owner: dbeam@chromium.org
I can be the engineering PoC for now :)

Comment 8 by dbeam@chromium.org, Nov 28

Status: Started (was: Available)

Comment 9 by bugdroid1@chromium.org, Dec 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b8893023c3cfd0b6366746235e7113f2ce8d8cb

commit 3b8893023c3cfd0b6366746235e7113f2ce8d8cb
Author: Dan Beam <dbeam@chromium.org>
Date: Sat Dec 01 01:40:50 2018

Dark Mode: add a base::Feature to respond to dark mode in WebUI

Example combined usage CL: https://crrev.com/c/1354685

BUG=883049
R=thestig@chromium.org

Change-Id: Ie6f44e2095a0c59738acec58b478b5a5e22bbd2f
Reviewed-on: https://chromium-review.googlesource.com/c/1357627
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612896}
[modify] https://crrev.com/3b8893023c3cfd0b6366746235e7113f2ce8d8cb/chrome/browser/browser_features.cc
[modify] https://crrev.com/3b8893023c3cfd0b6366746235e7113f2ce8d8cb/chrome/browser/browser_features.h

Comment 10 by bugdroid1@chromium.org, Dec 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fc92becf2068f17840f4af67564b18391509d6f

commit 7fc92becf2068f17840f4af67564b18391509d6f
Author: Dan Beam <dbeam@chromium.org>
Date: Mon Dec 03 20:48:55 2018

Dark Mode: split out TestNativeTheme as a separate class/target

There was a handy dandy testing version of NativeTheme in
view_unittest.cc that I'd like to reuse in upcoming unit tests for WebUI
Dark Mode support (https://crrev.com/c/1354685).

BUG=883049
R=sky@chromium.org

Change-Id: Ie39f6c42f5069450ec9933b1b83d4cb615ab713d
Reviewed-on: https://chromium-review.googlesource.com/c/1357607
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613233}
[modify] https://crrev.com/7fc92becf2068f17840f4af67564b18391509d6f/ui/native_theme/BUILD.gn
[add] https://crrev.com/7fc92becf2068f17840f4af67564b18391509d6f/ui/native_theme/test_native_theme.cc
[add] https://crrev.com/7fc92becf2068f17840f4af67564b18391509d6f/ui/native_theme/test_native_theme.h
[modify] https://crrev.com/7fc92becf2068f17840f4af67564b18391509d6f/ui/views/BUILD.gn
[modify] https://crrev.com/7fc92becf2068f17840f4af67564b18391509d6f/ui/views/view_unittest.cc

Comment 11 by bugdroid1@chromium.org, Dec 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e59ccd943021c6ff6a7a928ed90bac483e57551c

commit e59ccd943021c6ff6a7a928ed90bac483e57551c
Author: Dan Beam <dbeam@chromium.org>
Date: Mon Dec 03 23:57:07 2018

Dark Mode / WebUI: make TestWebUI auto-register message handlers

This makes test code easier to write and understand and is also what the
"prod" WebUI class already does.

This is loosely related to Dark Mode support, as I discovered this
difference in behavior while working on unit tests for this work.

WIP Dark Mode CL: https://crrev.com/c/1354685

R=jam@chromium.org
BUG=883049

Change-Id: I6862e2cd0244bdb02bd6dd92870bc2ec70d2099a
Reviewed-on: https://chromium-review.googlesource.com/c/1359132
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613332}
[modify] https://crrev.com/e59ccd943021c6ff6a7a928ed90bac483e57551c/content/public/browser/web_ui_message_handler.h
[modify] https://crrev.com/e59ccd943021c6ff6a7a928ed90bac483e57551c/content/public/test/test_web_ui.cc

Comment 12 by bugdroid1@chromium.org, Dec 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/432976afd3b4952ad28595b561febd4eaa572ef6

commit 432976afd3b4952ad28595b561febd4eaa572ef6
Author: Dan Beam <dbeam@chromium.org>
Date: Tue Dec 04 07:32:54 2018

Dark Mode: make a testable WebUIDataSource for unit tests

There was no easy way to get at the set load time data keys/values nor
the $i18n{} placeholder strings.  My upcoming work for dark mode
requires a key be set whether or not dark mode is enabled or on.

I'm adding TestWebUIDataSource in hopes that it's more generically
useful, as TestWebUI has been.

Example use here: https://crrev.com/c/1354685

R=sky@chromium.org
BUG=883049

Change-Id: I2214fcbd4693f82e44d0a0e679c993391c64fba8
Reviewed-on: https://chromium-review.googlesource.com/c/1357612
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613461}
[modify] https://crrev.com/432976afd3b4952ad28595b561febd4eaa572ef6/content/browser/webui/url_data_source_impl.h
[modify] https://crrev.com/432976afd3b4952ad28595b561febd4eaa572ef6/content/browser/webui/web_ui_data_source_impl.cc
[modify] https://crrev.com/432976afd3b4952ad28595b561febd4eaa572ef6/content/browser/webui/web_ui_data_source_impl.h
[add] https://crrev.com/432976afd3b4952ad28595b561febd4eaa572ef6/content/public/test/test_web_ui_data_source.cc
[add] https://crrev.com/432976afd3b4952ad28595b561febd4eaa572ef6/content/public/test/test_web_ui_data_source.h
[modify] https://crrev.com/432976afd3b4952ad28595b561febd4eaa572ef6/content/test/BUILD.gn

Comment 13 by bugdroid1@chromium.org, Dec 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7ab4d1cfd8f7ba99895ac2be734baf3d4f5a5a2

commit e7ab4d1cfd8f7ba99895ac2be734baf3d4f5a5a2
Author: Dan Beam <dbeam@chromium.org>
Date: Tue Dec 04 20:35:24 2018

Dark Mode: add WebUI handlers for querying/observing theme

To make your page track dark mode, do something like:

  #include "chrome/browser/ui/webui/dark_mode_handler.h"
  ...
  DarkModeHandler::Initialize(web_ui, data_source);

R=dpapad@chromium.org
BUG=883049

Change-Id: Ic58478513c3917f663cb29436cf79a3d59d53470
Reviewed-on: https://chromium-review.googlesource.com/c/1359456
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613682}
[modify] https://crrev.com/e7ab4d1cfd8f7ba99895ac2be734baf3d4f5a5a2/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/e7ab4d1cfd8f7ba99895ac2be734baf3d4f5a5a2/chrome/browser/ui/webui/dark_mode_handler.cc
[add] https://crrev.com/e7ab4d1cfd8f7ba99895ac2be734baf3d4f5a5a2/chrome/browser/ui/webui/dark_mode_handler.h
[add] https://crrev.com/e7ab4d1cfd8f7ba99895ac2be734baf3d4f5a5a2/chrome/browser/ui/webui/dark_mode_handler_unittest.cc
[modify] https://crrev.com/e7ab4d1cfd8f7ba99895ac2be734baf3d4f5a5a2/chrome/test/BUILD.gn
[modify] https://crrev.com/e7ab4d1cfd8f7ba99895ac2be734baf3d4f5a5a2/content/browser/webui/web_ui_data_source_impl.h
[modify] https://crrev.com/e7ab4d1cfd8f7ba99895ac2be734baf3d4f5a5a2/content/public/browser/web_ui_data_source.h

Comment 14 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1793df0e4ba009b98744de629534a7f000716341

commit 1793df0e4ba009b98744de629534a7f000716341
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Dec 07 01:12:05 2018

Dark Mode: give user-facing WebUI pages data on whether dark mode is on

R=dpapad@chromium.org
BUG=883049

Change-Id: Ia0657f1333ee3c3e556b36515f97c66a666309d9
Reviewed-on: https://chromium-review.googlesource.com/c/1354685
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614531}
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/resources/md_bookmarks/bookmarks.html
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/resources/md_downloads/downloads.html
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/resources/md_extensions/extensions.html
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/resources/md_history/history.html
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/resources/md_user_manager/user_manager.html
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/resources/print_preview/print_preview_new.html
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/resources/settings/settings.html
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/ui/webui/dark_mode_handler.cc
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/ui/webui/dark_mode_handler.h
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/ui/webui/dark_mode_handler_unittest.cc
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/ui/webui/md_history_ui.cc
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/chrome/browser/ui/webui/signin/md_user_manager_ui.cc
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/third_party/closure_compiler/externs/pending.js
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/ui/webui/resources/PRESUBMIT.py
[add] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/ui/webui/resources/html/dark_mode.html
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/ui/webui/resources/js/BUILD.gn
[add] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/ui/webui/resources/js/dark_mode.js
[modify] https://crrev.com/1793df0e4ba009b98744de629534a7f000716341/ui/webui/resources/webui_resources.grd

Comment 15 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0886a69f4c1ffe28aa10b41c6d31d18b5709f90a

commit 0886a69f4c1ffe28aa10b41c6d31d18b5709f90a
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Dec 14 22:43:55 2018

Dark Mode: update Settings loading shell

R=dpapad@chromium.org
BUG=883049

Change-Id: Idf98a94cc1767abc897a546767361447ad637e2b
Reviewed-on: https://chromium-review.googlesource.com/c/1377382
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616859}
[modify] https://crrev.com/0886a69f4c1ffe28aa10b41c6d31d18b5709f90a/chrome/browser/resources/settings/settings.html

Comment 16 by bugdroid1@chromium.org, Dec 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11f0bd52f6d61fbd59f4190b16f9310fb8632265

commit 11f0bd52f6d61fbd59f4190b16f9310fb8632265
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Dec 26 22:52:18 2018

Dark Mode: update Downloads loading shell

R=dpapad@chromium.org
BUG=883049

Change-Id: Ic022236ade3eb6f2133346843cf196a6b5ac251c
Reviewed-on: https://chromium-review.googlesource.com/c/1377386
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618975}
[modify] https://crrev.com/11f0bd52f6d61fbd59f4190b16f9310fb8632265/chrome/browser/resources/md_downloads/downloads.html
[modify] https://crrev.com/11f0bd52f6d61fbd59f4190b16f9310fb8632265/chrome/browser/resources/md_downloads/manager.html

Comment 17 by bugdroid1@chromium.org, Dec 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6bbc7a6ad37a4b684fbd6081e1659c5aca79644

commit d6bbc7a6ad37a4b684fbd6081e1659c5aca79644
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Dec 28 00:01:08 2018

Dark Mode: update md_colors.css

These variables are used in various places, but I'm mainly updating
because bookmarks and history load this stylesheet remotely and use the
--md-* vars for their loading shells.

R=aee@chromium.org
BUG=883049

Change-Id: I161746c93268d82987f6a14d885180017678c804
Reviewed-on: https://chromium-review.googlesource.com/c/1378565
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619096}
[modify] https://crrev.com/d6bbc7a6ad37a4b684fbd6081e1659c5aca79644/ui/webui/resources/css/md_colors.css

Comment 18 by bugdroid1@chromium.org, Dec 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5421314f6f0df670b22c5ee1e3ccb15397d572f

commit b5421314f6f0df670b22c5ee1e3ccb15397d572f
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Dec 28 00:21:21 2018

Dark Mode: update History loading shell

R=aee@chromium.org
BUG=883049

Change-Id: I5b9b99db769ba786d00c3fc5b114324f47b32d12
Reviewed-on: https://chromium-review.googlesource.com/c/1378677
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619098}
[modify] https://crrev.com/b5421314f6f0df670b22c5ee1e3ccb15397d572f/chrome/browser/resources/md_history/history.html

Comment 19 by bugdroid1@chromium.org, Dec 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9b0dcabe8faa04247e5969f039bd7993b2b0674

commit d9b0dcabe8faa04247e5969f039bd7993b2b0674
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Dec 28 00:56:04 2018

Dark Mode: update Bookmarks loading shell

R=aee@chromium.org
BUG=883049

Change-Id: I9bde2e01cd9e06072cd0c5109a0b06ef0594edef
Reviewed-on: https://chromium-review.googlesource.com/c/1378586
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619104}
[modify] https://crrev.com/d9b0dcabe8faa04247e5969f039bd7993b2b0674/chrome/browser/resources/md_bookmarks/app.js
[modify] https://crrev.com/d9b0dcabe8faa04247e5969f039bd7993b2b0674/chrome/browser/resources/md_bookmarks/bookmarks.html

Comment 20 by dbeam@chromium.org, Dec 28

general FYI:

  $ path/to/chrome --enable-features=WebUIDarkMode --force-dark-mode

to see this in action locally on any platform.

Comment 21 by bugdroid1@chromium.org, Dec 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/612cae656e26cc9b3b9453314a984c32009844f2

commit 612cae656e26cc9b3b9453314a984c32009844f2
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Dec 28 19:23:58 2018

Dark Mode: split color variables to top of shared_vars_css.html

This allows us to set light/dark mode variants at the top and reuse them
throughout the file (and elsewhere, in some cases). I also made use of
some of the variables in some cr_elements (i.e. toolbar, menu, etc.).

I also start looking at some of the pages with --force-dark-mode on and
fixed small stuff to make them readable. Generally I wanted to make
cards the right color and text readable. Various pages (i.e. settings,
downloads, history, bookmarks) look terrible but are actually dark now.

R=aee@chromium.org
BUG=883049

Change-Id: I8923dc7cac7680641aa5d3c4f5a35f20441dafce
Reviewed-on: https://chromium-review.googlesource.com/c/1391912
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619175}
[modify] https://crrev.com/612cae656e26cc9b3b9453314a984c32009844f2/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/612cae656e26cc9b3b9453314a984c32009844f2/chrome/browser/resources/md_downloads/item.html
[modify] https://crrev.com/612cae656e26cc9b3b9453314a984c32009844f2/chrome/browser/resources/md_downloads/toolbar.html
[modify] https://crrev.com/612cae656e26cc9b3b9453314a984c32009844f2/chrome/browser/resources/md_extensions/item.html
[modify] https://crrev.com/612cae656e26cc9b3b9453314a984c32009844f2/chrome/browser/resources/md_extensions/keyboard_shortcuts.html
[modify] https://crrev.com/612cae656e26cc9b3b9453314a984c32009844f2/chrome/browser/resources/md_history/history_item.html
[modify] https://crrev.com/612cae656e26cc9b3b9453314a984c32009844f2/chrome/browser/resources/md_history/synced_device_card.html
[modify] https://crrev.com/612cae656e26cc9b3b9453314a984c32009844f2/chrome/browser/resources/settings/settings_page/settings_section.html
[modify] https://crrev.com/612cae656e26cc9b3b9453314a984c32009844f2/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/612cae656e26cc9b3b9453314a984c32009844f2/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html
[modify] https://crrev.com/612cae656e26cc9b3b9453314a984c32009844f2/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
[modify] https://crrev.com/612cae656e26cc9b3b9453314a984c32009844f2/ui/webui/resources/cr_elements/shared_vars_css.html
[modify] https://crrev.com/612cae656e26cc9b3b9453314a984c32009844f2/ui/webui/resources/html/action_link_css.html

Comment 22 by bugdroid1@chromium.org, Dec 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6d38fef3ae98e8735a3377e8e38b1db1819b01e

commit e6d38fef3ae98e8735a3377e8e38b1db1819b01e
Author: Dan Beam <dbeam@chromium.org>
Date: Sat Dec 29 00:21:47 2018

Dark Mode: update Extensions loading shell

--enable-features=WebUIDarkMode --force-dark-mode to see locally.

R=rdevlin.cronin@chromium.org
BUG=883049

Change-Id: Ie34afa4952afe33f86336f49a82edc5387bc43e0
Reviewed-on: https://chromium-review.googlesource.com/c/1378682
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619212}
[modify] https://crrev.com/e6d38fef3ae98e8735a3377e8e38b1db1819b01e/chrome/browser/resources/md_extensions/extensions.html

Comment 23 by bugdroid1@chromium.org, Jan 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eae570f9546e087bbf584a502808ff5c13571634

commit eae570f9546e087bbf584a502808ff5c13571634
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Jan 02 23:21:12 2019

Dark Mode: add a better way of creating opacity variants of colors

Previously, there were things like:

  --some-color: #010203;
  --some-color-opacity-X: rgba(1, 2, 3, X);

Which is a bit inflexible and leads to a bit of redundancy. Instead,
let's use this syntax, which allows minting an arbitrary number of
colors with var() + rgba() syntax:

  --some-color-rgb: 1, 2, 3;
  --some-color: rgb(var(--some-color));
  /* later ... */
  color: rgba(var(--some-color-rgb), X /* any opacity */);

Bug: 883049
Change-Id: If730a1123294e43f2ea04b433c6c5a46933cc08e
Reviewed-on: https://chromium-review.googlesource.com/c/1393442
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619532}
[modify] https://crrev.com/eae570f9546e087bbf584a502808ff5c13571634/chrome/browser/resources/settings/device_page/night_light_slider.html
[modify] https://crrev.com/eae570f9546e087bbf584a502808ff5c13571634/ui/webui/resources/cr_elements/cr_slider/cr_slider.html
[modify] https://crrev.com/eae570f9546e087bbf584a502808ff5c13571634/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
[modify] https://crrev.com/eae570f9546e087bbf584a502808ff5c13571634/ui/webui/resources/cr_elements/paper_button_style_css.html
[modify] https://crrev.com/eae570f9546e087bbf584a502808ff5c13571634/ui/webui/resources/cr_elements/shared_vars_css.html

Comment 24 by bugdroid1@chromium.org, Jan 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2eb9fbc918fb89896c2869af5015468b036d00a8

commit 2eb9fbc918fb89896c2869af5015468b036d00a8
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Jan 04 06:43:27 2019

Dark Mode: start fixing up downloads to look like specs

Screenshots: https://imgur.com/a/mcoKkKc
Specs: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit#slide=id.g471d243f08_0_874

There's still a bit of work to be done (notably: buttons),
but this gets us closer to Namrata's mocks.

To run locally, use --enable-features=WebUIDarkMode --force-dark-mode

BUG=883049
R=hcarmona@chromium.org

Change-Id: I232adf9b487d8be2042c5123484fdb6f87da13c4
Reviewed-on: https://chromium-review.googlesource.com/c/1377147
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619893}
[modify] https://crrev.com/2eb9fbc918fb89896c2869af5015468b036d00a8/chrome/browser/resources/md_downloads/item.html
[modify] https://crrev.com/2eb9fbc918fb89896c2869af5015468b036d00a8/chrome/browser/resources/md_downloads/manager.html
[modify] https://crrev.com/2eb9fbc918fb89896c2869af5015468b036d00a8/chrome/browser/resources/md_downloads/toolbar.html
[modify] https://crrev.com/2eb9fbc918fb89896c2869af5015468b036d00a8/ui/webui/resources/cr_elements/shared_vars_css.html

Comment 25 by bugdroid1@chromium.org, Jan 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d69b6b5d6dd36313a35b07f0912379499e32fc3

commit 0d69b6b5d6dd36313a35b07f0912379499e32fc3
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Jan 09 22:46:19 2019

Dark Mode: change downloads paper-progress colors

Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit#slide=id.g4a64df24f4_20_0

R=aee@chromium.org
BUG=883049

Change-Id: Ice71c5ff0a9e640343a3c602154f410386944d72
Reviewed-on: https://chromium-review.googlesource.com/c/1403347
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621344}
[modify] https://crrev.com/0d69b6b5d6dd36313a35b07f0912379499e32fc3/chrome/browser/resources/md_downloads/item.html

Comment 26 by bugdroid1@chromium.org, Jan 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcca5677255f71457ba3918db68f322c8e31c9de

commit dcca5677255f71457ba3918db68f322c8e31c9de
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Jan 09 22:53:26 2019

Dark Mode: generate lots of -rgb versions of --google colors

This is so various places can do something like:

  color: rgba(var(--google-blue-500-rgb), .1234);

To mint arbitrary amounts of semi-opaque colors.

R=dpapad@chromium.org
BUG=883049

Change-Id: I48699241cc445f3099a288ab0577107a707bb78a
Reviewed-on: https://chromium-review.googlesource.com/c/1399512
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621350}
[modify] https://crrev.com/dcca5677255f71457ba3918db68f322c8e31c9de/third_party/polymer/v1_0/PRESUBMIT.py
[modify] https://crrev.com/dcca5677255f71457ba3918db68f322c8e31c9de/third_party/polymer/v1_0/components-chromium/paper-styles/color.html
[modify] https://crrev.com/dcca5677255f71457ba3918db68f322c8e31c9de/third_party/polymer/v1_0/reproduce.sh
[add] https://crrev.com/dcca5677255f71457ba3918db68f322c8e31c9de/third_party/polymer/v1_0/rgbify_hex_vars.py
[add] https://crrev.com/dcca5677255f71457ba3918db68f322c8e31c9de/third_party/polymer/v1_0/rgbify_hex_vars_test.py
[modify] https://crrev.com/dcca5677255f71457ba3918db68f322c8e31c9de/ui/webui/resources/cr_elements/paper_button_style_css.html
[modify] https://crrev.com/dcca5677255f71457ba3918db68f322c8e31c9de/ui/webui/resources/cr_elements/shared_vars_css.html

Comment 28 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e82714bef207493ab3a29f692dbe587d5a71392

commit 2e82714bef207493ab3a29f692dbe587d5a71392
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Jan 10 21:56:29 2019

Dark Mode: fix warning color

Screenshots: https://imgur.com/a/NcdRQk1 (less bright is correct)

R=rbpotter@chromium.org
BUG=883049

Change-Id: I764f25d64c7f3b9766a2d9abfeb315b9b928fded
Reviewed-on: https://chromium-review.googlesource.com/c/1403987
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621763}
[modify] https://crrev.com/2e82714bef207493ab3a29f692dbe587d5a71392/chrome/browser/resources/md_downloads/item.html
[modify] https://crrev.com/2e82714bef207493ab3a29f692dbe587d5a71392/ui/webui/resources/cr_elements/shared_vars_css.html

Comment 29 by cyflee@chromium.org, Jan 11

Cc: cyflee@chromium.org

Comment 30 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cfb095f09183890455d45cd5695d67eda28d6a7

commit 4cfb095f09183890455d45cd5695d67eda28d6a7
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Jan 11 05:51:01 2019

Dark Mode: fix accidentally removed dependency

Certain shades of our Google palette are only in shared_vars_css.html,
not in paper-styles/color.html

https://crrev.com/c/1399512 made that faulty assumption.

This broke buttons on many pages (i.e. welcome, sign in dialog, etc.)

TBR=dpapad@chromium.org
BUG=883049, 920540 , 920537 

Change-Id: I7b019f90007612fb020b33535b79410447ca8666
Reviewed-on: https://chromium-review.googlesource.com/c/1405724
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621921}
[modify] https://crrev.com/4cfb095f09183890455d45cd5695d67eda28d6a7/ui/webui/resources/cr_elements/paper_button_style_css.html

Comment 31 by dbeam@chromium.org, Jan 15

Blockedon: 921688

Comment 32 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49703970600890683685ca1b99e845705a68f586

commit 49703970600890683685ca1b99e845705a68f586
Author: Dan Beam <dbeam@chromium.org>
Date: Tue Jan 15 05:13:50 2019

Dark Mode: make downloads item separator border fully opaque

Request from Namrata.

R=aee@chromium.org
BUG=883049

Change-Id: I0421fa21a9d9cb3b7b543b131437142f8dbb176f
Reviewed-on: https://chromium-review.googlesource.com/c/1409921
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622738}
[modify] https://crrev.com/49703970600890683685ca1b99e845705a68f586/chrome/browser/resources/md_downloads/item.html

Comment 33 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91576a07eee92259e583f026c5da3dcc998265fc

commit 91576a07eee92259e583f026c5da3dcc998265fc
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Jan 17 02:44:35 2019

Dark Mode: add GM2 Google Blue 300 and update link colors

Because of an unfortunate miscommunication, I assumed colors in the
WebUI Dark Mode spec were from the Material Design (MD) palette instead
of the Material Modern/Refresh (GM2) version. Whoops.

There's probably a lot more colors to update soon.

R=hcarmona@chromium.org
BUG=883049

Change-Id: Idcc8b7a0e811aa1dbe6a5abafcf58544b8dc3988
Reviewed-on: https://chromium-review.googlesource.com/c/1416771
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623532}
[modify] https://crrev.com/91576a07eee92259e583f026c5da3dcc998265fc/ui/webui/resources/cr_elements/shared_vars_css.html

Comment 34 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ae9decb48da495b41fa5f5b4c7242eb810e5744

commit 7ae9decb48da495b41fa5f5b4c7242eb810e5744
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Jan 17 03:31:05 2019

Dark Mode: update history time gap separator color

R=dpapad@chromium.org
BUG=883049

Change-Id: I23f3973721ae92fbb65d6e346e35a6e48a464615
Reviewed-on: https://chromium-review.googlesource.com/c/1416818
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623553}
[modify] https://crrev.com/7ae9decb48da495b41fa5f5b4c7242eb810e5744/chrome/browser/resources/md_history/history_item.html

Comment 35 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e1388e870679122fe84fc3a04867d170802269e

commit 9e1388e870679122fe84fc3a04867d170802269e
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Jan 17 03:42:38 2019

Dark Mode: spruce up history page (and cr-{checkbox,drawer,toolbar})

There's still a bit to do on history, but this gets us a ways.

Screenshots: https://imgur.com/a/ngXdLK4
Specs: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g481b97d74a_0_389

BUG=883049
R=aee@chromium.org

Change-Id: Ifb34e89d2d3ea47b145ba012c1bd5975af59bf56
Reviewed-on: https://chromium-review.googlesource.com/c/1409969
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623560}
[modify] https://crrev.com/9e1388e870679122fe84fc3a04867d170802269e/chrome/browser/resources/md_history/app.html
[modify] https://crrev.com/9e1388e870679122fe84fc3a04867d170802269e/chrome/browser/resources/md_history/history.html
[modify] https://crrev.com/9e1388e870679122fe84fc3a04867d170802269e/chrome/browser/resources/md_history/shared_style.html
[modify] https://crrev.com/9e1388e870679122fe84fc3a04867d170802269e/chrome/browser/resources/md_history/shared_vars.html
[modify] https://crrev.com/9e1388e870679122fe84fc3a04867d170802269e/chrome/browser/resources/md_history/side_bar.html
[modify] https://crrev.com/9e1388e870679122fe84fc3a04867d170802269e/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html
[modify] https://crrev.com/9e1388e870679122fe84fc3a04867d170802269e/ui/webui/resources/cr_elements/cr_drawer/cr_drawer.html
[modify] https://crrev.com/9e1388e870679122fe84fc3a04867d170802269e/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html

Comment 36 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5d06ec3166a01c8cd2836b811f28c566257386e

commit c5d06ec3166a01c8cd2836b811f28c566257386e
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Jan 17 20:46:05 2019

Dark Mode: fix loading and search results message color

Screenshots: https://imgur.com/a/dPACewN

BUG=883049
R=aee@chromium.org

Change-Id: I10fceb7a9df0e860c44dde7dc0f974a1b87a1642
Reviewed-on: https://chromium-review.googlesource.com/c/1415812
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623828}
[modify] https://crrev.com/c5d06ec3166a01c8cd2836b811f28c566257386e/ui/webui/resources/css/md_colors.css

Comment 38 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f174f7423a27bfb7e8774271a326c618621f1cb5

commit f174f7423a27bfb7e8774271a326c618621f1cb5
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Jan 17 23:06:24 2019

Dark Mode: fix dialog backgrounds

Screenshots: https://imgur.com/a/tJxmUkI

R=aee@chromium.org
BUG=883049

Change-Id: I0563bff018460c48d8ede60f5e77b54cf823714e
Reviewed-on: https://chromium-review.googlesource.com/c/1415841
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623890}
[modify] https://crrev.com/f174f7423a27bfb7e8774271a326c618621f1cb5/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Comment 39 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74295a765b323f697908d07e4210b41b23070f79

commit 74295a765b323f697908d07e4210b41b23070f79
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Jan 17 23:19:49 2019

Dark Mode: update cr-toolbar-selection-overlay

Screenshots: https://imgur.com/a/SWCmFcu

BUG=883049
R=dpapad@chromium.org

Change-Id: Id0ff197c01a8cb4876739155fbac153bc6c6736c
Reviewed-on: https://chromium-review.googlesource.com/c/1417121
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623900}
[modify] https://crrev.com/74295a765b323f697908d07e4210b41b23070f79/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html

Comment 40 by dbeam@chromium.org, Jan 18

Blockedon: 923224

Comment 41 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba8dc4f259adf48fbddd829d4548ec083daddd35

commit ba8dc4f259adf48fbddd829d4548ec083daddd35
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Jan 18 17:58:53 2019

Dark Mode: fix a bunch of wrong colors

When I first started working on this project, the spec had a bunch of
"GG 500" and "GB 300", which to me meant the Material Design colors.

But there's actually a new version of the color palette (GM2) with the
same names, which is a bit of a bummer.

Even more confusingly, various variables in the code use the same naming
scheme as Material Design but for GM2. Ex:

  --google-grey-100 -> Material Design
  --google-grey-200 -> GM2

There are -refresh version of colors, which mean the GM2 equivalent.

  --google-grey-500 -> Material Design
  --google-grey-refresh-500 -> GM2

This is fairly nuts.

Anyways, cuz I'm still mildly hoping WebUI dark mode makes Chrome 73, I
grepped for all the places that use [dark] and then looked for possibly
wrong colors. Here's the command I used:

  $ git gs '\[dark\]' -l | xargs egrep -l \
    '\-\-google-(green|red|blue|grey|gray|yellow)-[1357]00'

And updated the files I found.

I also added some new GM2 equivalents (more -refresh colors) and ran
third_party/polymer/v1_0/rgbify_hex_vars.py on it to produce the -rgb
versions.

BUG=883049
R=dpapad@chromium.org

Change-Id: Ic1160931d70c84fb4cb700a4047e686a93dfbc09
Reviewed-on: https://chromium-review.googlesource.com/c/1415815
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624194}
[modify] https://crrev.com/ba8dc4f259adf48fbddd829d4548ec083daddd35/chrome/browser/resources/md_downloads/item.html
[modify] https://crrev.com/ba8dc4f259adf48fbddd829d4548ec083daddd35/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
[modify] https://crrev.com/ba8dc4f259adf48fbddd829d4548ec083daddd35/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html
[modify] https://crrev.com/ba8dc4f259adf48fbddd829d4548ec083daddd35/ui/webui/resources/cr_elements/paper_button_style_css.html
[modify] https://crrev.com/ba8dc4f259adf48fbddd829d4548ec083daddd35/ui/webui/resources/cr_elements/shared_vars_css.html

Comment 42 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d442d2088b3ec6e06f942ef710be3059b7093e6e

commit d442d2088b3ec6e06f942ef710be3059b7093e6e
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Jan 18 20:06:46 2019

Dark Mode: update paper-icon-button-light's ripple opacity

The only real change here is +25% effective opacity by raising both the
opacity of the <paper-ripple> (60% -> 100%) and the <div class="ripple">
inside of it (25% -> 40%) as the spec calls for 40% of the text color.

Screenshot: https://imgur.com/a/gxC4zy4
Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g364d7f9db1_0_0

R=dpapad@chromium.org
BUG=883049

Change-Id: Ib8f2921ce1ac3317cdaebcc8ce0e482c70159931
Reviewed-on: https://chromium-review.googlesource.com/c/1420118
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624250}
[modify] https://crrev.com/d442d2088b3ec6e06f942ef710be3059b7093e6e/ui/webui/resources/cr_elements/cr_icons_css.html

Comment 43 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1c7c0543ceb3801a191fe15e9bfa16ac6b10d28

commit e1c7c0543ceb3801a191fe15e9bfa16ac6b10d28
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Jan 18 21:48:08 2019

Dark Mode: stop light mode styles from bleeding into dark mode buttons

Light mode, secondary paper-button:hover border-color was coming through
because an equivalent variable wasn't being defined for dark mode.

It's very hard to see, but I think the same story was happening for
primary paper-button:active box-shadow.

Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g471d243f08_0_869

R=dpapad@chromium.org
BUG=883049

Change-Id: I3db4f2cde037d33086408e980eea43979cc0fe99
Reviewed-on: https://chromium-review.googlesource.com/c/1420304
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624305}
[modify] https://crrev.com/e1c7c0543ceb3801a191fe15e9bfa16ac6b10d28/ui/webui/resources/cr_elements/paper_button_style_css.html

Comment 44 by dbeam@chromium.org, Jan 19

Blockedon: 923597

Comment 45 by bugdroid1@chromium.org, Jan 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fc1894e95171615e1576c81c3378ab773fccdc5

commit 4fc1894e95171615e1576c81c3378ab773fccdc5
Author: Dan Beam <dbeam@chromium.org>
Date: Sat Jan 19 02:26:43 2019

Dark Mode: use standard loading message color on bookmarks

Screenshots: https://imgur.com/a/dJrfydP (lighter is correct)

R=dpapad@chromium.org
BUG=883049

Change-Id: Iceacdb75ba7d78a541a2fad29af455fd2a8bc78f
Reviewed-on: https://chromium-review.googlesource.com/c/1423637
Commit-Queue: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624424}
[modify] https://crrev.com/4fc1894e95171615e1576c81c3378ab773fccdc5/chrome/browser/resources/bookmarks/list.html

Comment 46 by bugdroid1@chromium.org, Jan 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9add6dee6de2fd07613c576488aa450248b4768

commit f9add6dee6de2fd07613c576488aa450248b4768
Author: Dan Beam <dbeam@chromium.org>
Date: Sat Jan 19 04:11:05 2019

Dark Mode: update Bookmarks page folder icons and selection colors

Folder icons:

Use -webkit-mask-image instead of background-image allows us to change
the color of the fill dynamically. This means we can create light/dark
with the same .svg.

Selection colors:

Dark mode needs more code for selection (than light mode) because the
specs call for inverting the background to light blue (so the text and
icons must be flipped to dark on light, whereas they're typically light
on dark).

I also strove to generally simplify some border/background color logic
by using currentcolor, which lets other properties use the text color
as a value.

Screenshots: https://imgur.com/a/TDqd9KY
Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g481b97d74a_0_342

BUG=883049
R=dpapad@chromium.org

Change-Id: I4ff4ec2d6f29fbdd637e00e2c6818eb26d0b5c1b
Reviewed-on: https://chromium-review.googlesource.com/c/1423701
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624439}
[modify] https://crrev.com/f9add6dee6de2fd07613c576488aa450248b4768/chrome/browser/resources/bookmarks/folder_node.html
[modify] https://crrev.com/f9add6dee6de2fd07613c576488aa450248b4768/chrome/browser/resources/bookmarks/item.html
[modify] https://crrev.com/f9add6dee6de2fd07613c576488aa450248b4768/chrome/browser/resources/bookmarks/list.html
[modify] https://crrev.com/f9add6dee6de2fd07613c576488aa450248b4768/chrome/browser/resources/bookmarks/shared_style.html
[modify] https://crrev.com/f9add6dee6de2fd07613c576488aa450248b4768/chrome/browser/resources/bookmarks/shared_vars.html

Comment 47 by bugdroid1@chromium.org, Jan 21

Project Member

Comment 48 by bugdroid1@chromium.org, Jan 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a16576d9f32908cdf1cd7c223ff67fc5c0b13cb6

commit a16576d9f32908cdf1cd7c223ff67fc5c0b13cb6
Author: Dan Beam <dbeam@chromium.org>
Date: Tue Jan 22 00:31:37 2019

Dark Mode: fix details view background color on Extensions page

TBR=dpapad@chromium.org
BUG=883049

Change-Id: I1642e4abe437c455d2e06069f0823ba76a03989e
Reviewed-on: https://chromium-review.googlesource.com/c/1426169
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624702}
[modify] https://crrev.com/a16576d9f32908cdf1cd7c223ff67fc5c0b13cb6/chrome/browser/resources/md_extensions/shared_style.html

Comment 49 by bugdroid1@chromium.org, Jan 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e0fe58b3dcec8560f14660451bcc44b4f3145df

commit 0e0fe58b3dcec8560f14660451bcc44b4f3145df
Author: Dan Beam <dbeam@chromium.org>
Date: Tue Jan 22 19:07:57 2019

WebUI Dark Mode: update cr-toggle colors

Screenshots: https://imgur.com/a/i2uuR4y
Specs: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g3228466bab_0_40

R=dpapad@chromium.org
BUG=883049

Change-Id: I7e32f536f0b55f90320773aa1b53a7f392e5b985
Reviewed-on: https://chromium-review.googlesource.com/c/1426088
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624859}
[modify] https://crrev.com/0e0fe58b3dcec8560f14660451bcc44b4f3145df/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.html

Comment 50 by bugdroid1@chromium.org, Jan 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ea9e157dfc564dd2363563d798e4f1795cafd70

commit 8ea9e157dfc564dd2363563d798e4f1795cafd70
Author: Dan Beam <dbeam@chromium.org>
Date: Tue Jan 22 19:22:13 2019

Dark Mode: update cr-toast colors

Also moves some duplicate color styles into cr-toast itself (and uses
::slotted(*) to apply).

Screenshots: https://imgur.com/a/JXx291d
Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g48a476f4a5_2_63

R=dpapad@chromium.org
BUG=883049

Change-Id: I983b7cf9d6b63b5b45a2f8897f7a9cdf6d1de244
Reviewed-on: https://chromium-review.googlesource.com/c/1425967
Auto-Submit: Dan Beam <dbeam@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624866}
[modify] https://crrev.com/8ea9e157dfc564dd2363563d798e4f1795cafd70/chrome/browser/resources/bookmarks/toast_manager.html
[modify] https://crrev.com/8ea9e157dfc564dd2363563d798e4f1795cafd70/chrome/browser/resources/md_extensions/toolbar.html
[modify] https://crrev.com/8ea9e157dfc564dd2363563d798e4f1795cafd70/chrome/browser/resources/settings/autofill_page/passwords_section.html
[modify] https://crrev.com/8ea9e157dfc564dd2363563d798e4f1795cafd70/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/8ea9e157dfc564dd2363563d798e4f1795cafd70/chrome/browser/resources/settings/people_page/sync_controls.html
[modify] https://crrev.com/8ea9e157dfc564dd2363563d798e4f1795cafd70/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/8ea9e157dfc564dd2363563d798e4f1795cafd70/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/8ea9e157dfc564dd2363563d798e4f1795cafd70/ui/webui/resources/cr_elements/cr_toast/cr_toast.html

Comment 51 by bugdroid1@chromium.org, Jan 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1775d50000ba72ac41c4a2a4949b7a7243f3db20

commit 1775d50000ba72ac41c4a2a4949b7a7243f3db20
Author: Dan Beam <dbeam@chromium.org>
Date: Tue Jan 22 19:24:49 2019

Dark Mode: fix Extensions page dev mode toolbar and loading shell

Changes the background color of the "dev mode" bar to match spec (GM2
GG800) and removes bottom border (not in spec mocks).

Also changes the loading shell to match.

Screenshots: https://imgur.com/a/nbQBRik
Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g481b97d74a_0_359

R=dpapad@chromium.org
BUG=883049

Change-Id: I16aef0496775fd9b6b678085d26077c6525483a1
Reviewed-on: https://chromium-review.googlesource.com/c/1426158
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624870}
[modify] https://crrev.com/1775d50000ba72ac41c4a2a4949b7a7243f3db20/chrome/browser/resources/md_extensions/extensions.html
[modify] https://crrev.com/1775d50000ba72ac41c4a2a4949b7a7243f3db20/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/1775d50000ba72ac41c4a2a4949b7a7243f3db20/chrome/browser/resources/md_extensions/toolbar.html

Comment 52 by bugdroid1@chromium.org, Jan 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06ddaec4b101c2c1d845806bd0d55146870bc01b

commit 06ddaec4b101c2c1d845806bd0d55146870bc01b
Author: Dan Beam <dbeam@chromium.org>
Date: Tue Jan 22 20:05:17 2019

Dark Mode: fix primary/secondary button shadow colors

The spec was a little hard to read, but I think this is correct.

Screenshots: https://imgur.com/a/SqOdxgO
Specs: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g471d243f08_0_869

R=dpapad@chromium.org
BUG=883049

Change-Id: Ie377f7c4ba52a3a4540497b15b8a7bb8ad67853a
Reviewed-on: https://chromium-review.googlesource.com/c/1426157
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624887}
[modify] https://crrev.com/06ddaec4b101c2c1d845806bd0d55146870bc01b/ui/webui/resources/cr_elements/paper_button_style_css.html

Comment 55 by dpa...@chromium.org, Jan 23

Blockedon: 924374

Comment 56 by dbeam@chromium.org, Jan 23

Blockedon: 924387

Comment 57 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/869f2ca589514c0750eb8c46de04fdd116e33c63

commit 869f2ca589514c0750eb8c46de04fdd116e33c63
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Jan 23 01:15:38 2019

WebUI Dark Mode: update cr-radio-button colors

Screenshots: https://imgur.com/a/wEShNS0
Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g364d7f9db1_0_8

Bug: 883049
Change-Id: I675df4e74c8530de14a3b9dc662c61446a715f6d
Reviewed-on: https://chromium-review.googlesource.com/c/1427741
Commit-Queue: Dan Beam <dbeam@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625014}

Comment 58 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5db16d6cdcfddd547b9c396630df79c1a7e3cfba

commit 5db16d6cdcfddd547b9c396630df79c1a7e3cfba
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Jan 23 02:22:25 2019

WebUI Dark Mode: style <select class="md-select"> for all pages

Screenshots: https://imgur.com/a/zioTkR5
Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g3b4ff0456d_0_9

R=dpapad@chromium.org
BUG=883049

Change-Id: I1e38c095af75ffbf574046891e5ad0427b4b4855
Reviewed-on: https://chromium-review.googlesource.com/c/1427456
Commit-Queue: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625041}

Comment 59 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df1a1e5b0cad09deff8aa9b19bf8e97031606710

commit df1a1e5b0cad09deff8aa9b19bf8e97031606710
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Jan 23 04:22:11 2019

WebUI Dark Mode: update [default] separator colors on all pages

Fix an accidental top border on the first row of Autofill settings
section. It was there but not particularly visible in light mode.

I originally thought the default separator color was GM2 GG 700 because
I started with downloads and theres a special separator color there
(between file icon and download details).

This change makes Settings and Extensions (details view) look much much
better: https://imgur.com/a/xvrYvc8

R=dpapad@chromium.org
BUG=883049

Change-Id: I6a50ffb6cc1f35f22f1b240db8a18c32b4692568
Reviewed-on: https://chromium-review.googlesource.com/c/1428561
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625085}

Comment 60 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1725fa339ca6415c61aa45043cc38f5f8dff6b3a

commit 1725fa339ca6415c61aa45043cc38f5f8dff6b3a
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Jan 23 06:15:57 2019

WebUI Dark Mode: fix settings sidenav colors

Screenshots: https://imgur.com/a/9VhTdfx

R=dpapad@chromium.org
BUG=883049

Change-Id: I75fab44827d25f89fc39e474419701dca4d306a4
Reviewed-on: https://chromium-review.googlesource.com/c/1428680
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625111}

Comment 61 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9bc80b18cd11ed474d87e0856ebca517513823a

commit d9bc80b18cd11ed474d87e0856ebca517513823a
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Jan 23 07:05:52 2019

WebUI Dark Mode: fix settings subpage backgrounds

TBR=dpapad@chromium.org
BUG=883049

Change-Id: Icdef0838145fbc7c207d1c3d57b9cb4d13d1cbb4
Reviewed-on: https://chromium-review.googlesource.com/c/1429759
Reviewed-by: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625118}

Comment 62 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/420990f58b3f0999bf14101b642c56a0ff2fe69a

commit 420990f58b3f0999bf14101b642c56a0ff2fe69a
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Jan 23 07:55:46 2019

WebUI Dark Mode: update cr-checkbox primary label color

This fixes, for example, chrome://settings/clearBrowserData checkboxes

TBR=dpapad@chromium.org
BUG=883049

Change-Id: I535c05ec0342a1e9fb735cfae1c48d38d10ae3d0
Reviewed-on: https://chromium-review.googlesource.com/c/1429665
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Reviewed-by: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625124}

Comment 63 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08832e65279677ca77b8e187bd7faf938dd22954

commit 08832e65279677ca77b8e187bd7faf938dd22954
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Jan 23 20:18:20 2019

WebUI Dark Mode: update paper-tabs selection and label colors

R=dpapad@chromium.org
BUG=883049

Change-Id: Ia9977c7eada06142181b2f4bc331c269ba88aeef
Reviewed-on: https://chromium-review.googlesource.com/c/1429664
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625330}

Comment 64 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79a39f9472afbc8fdad2506bfb426e2c6d06d908

commit 79a39f9472afbc8fdad2506bfb426e2c6d06d908
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Jan 23 21:40:18 2019

WebUI Dark Mode: fix title text color

This mainly affects section titles and subpage titles in settings.

R=dpapad@chromium.org
BUG=883049

Change-Id: I614cf44adb70becc5ef00479bd19c5372c4929c4
Reviewed-on: https://chromium-review.googlesource.com/c/1429661
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625371}

Comment 65 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d1b2c82abf3e0c65bdd6f3113def751a511dc52

commit 8d1b2c82abf3e0c65bdd6f3113def751a511dc52
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Jan 23 21:49:22 2019

WebUI Dark Mode: fix settings side bar icon color

In dark mode, the *icon* color differs slightly from the *text* color.

Screenshots: https://imgur.com/a/asWpYhY
Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g48a476f4a5_2_42

R=dpapad@chromium.org
BUG=883049

Change-Id: I67521d7505f1b27f212b4813c853074f88c28971
Reviewed-on: https://chromium-review.googlesource.com/c/1429196
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625374}

Comment 66 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7bc65893d43711ac82aef2b616e02fe1ce73a31

commit a7bc65893d43711ac82aef2b616e02fe1ce73a31
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Jan 23 22:28:13 2019

WebUI Dark Mode: rework link and error colors on Extensions page

Pretty much everything should use --cr-link-color, which magically
changes based on light/dark mode.

There was also just a ton of duplicated a[href] rules, which I
instead added to shared_style.html (and verified each place I
deleted from used include="shared-style").

Screenshots: https://imgur.com/a/kaT6MJc

R=dpapad@chromium.org
BUG=883049

Change-Id: I00440e1bcfaae21b31763f51d65385729ba7fab9
Reviewed-on: https://chromium-review.googlesource.com/c/1429379
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625386}

Comment 67 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d13a0e1389fb42eeab6d9d2b01ed1ea1b5e2773

commit 8d13a0e1389fb42eeab6d9d2b01ed1ea1b5e2773
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Jan 24 06:07:40 2019

WebUI Dark Mode: update .svg icons with embedded fill

This CL duplicates and updates the light mode .svg icons from
cr_icons_css.html to dark-specific equivalents. This was done
semi-mechanically with a bunch of sed hacking to copy and change the
fill color.  I also updated .md-select's icon as well.

I also renamed some icons that seemed to be overly presentation in their
naming (i.e. -white), changed the default --iron-icon-fill-color for
settings, deleted some unused shared variables, and added an error color
for settings.

Screenshots: https://imgur.com/a/MyI725P
Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c485b44#slide=id.g364d7f9db1_0_0

R=aee@chromium.org
BUG=883049

Change-Id: I7709044a360a2e78136c2123dbe17ea0de662e37
Reviewed-on: https://chromium-review.googlesource.com/c/1431916
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625527}

Comment 68 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/340e60088b1bd792c87f09b483a69dad24ec5b3b

commit 340e60088b1bd792c87f09b483a69dad24ec5b3b
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Jan 24 22:22:48 2019

WebUI Dark Mode: force user manager and print preview into light mode

This is in the unlikely event that dark mode actually makes it in 73.
These UIs are not ready yet.

R=dpapad@chromium.org
BUG=883049

Change-Id: Iaa79feadd8d341c4b730a9a6598f42c756070613
Reviewed-on: https://chromium-review.googlesource.com/c/1435517
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625843}

Comment 69 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18918f6f86dc6b3fff3035d93660c76e90ccac30

commit 18918f6f86dc6b3fff3035d93660c76e90ccac30
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Jan 24 23:29:12 2019

WebUI Dark Mode: update some cr-dialog separator colors

Screenshots: https://imgur.com/a/OQWcGpe

R=aee@chromium.org
BUG=883049

Change-Id: Ic2d0a5665b6f2aca20b20695219c3aa41c38774f
Reviewed-on: https://chromium-review.googlesource.com/c/1435516
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625870}

Comment 70 by bugdroid, Jan 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2823d03266f0f90b05479878eeae3ff96e67ca01

commit 2823d03266f0f90b05479878eeae3ff96e67ca01
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Jan 25 01:35:39 2019

WebUI Dark Mode: update cr-slider colors

Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g323037087e_1_0
Screenshots: https://imgur.com/a/NEz2kut

BUG=883049
R=aee@chromium.org

Change-Id: I240adbade23d0be584cb733c3c83acf113968b49
Reviewed-on: https://chromium-review.googlesource.com/c/1435680
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625936}

Comment 71 by bugdroid, Jan 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46982adc0b4bae80e04dd9579ad621fc5d4be384

commit 46982adc0b4bae80e04dd9579ad621fc5d4be384
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Jan 25 02:57:15 2019

WebUI Dark Mode: update cr-search-field background colors

Screenshots: https://imgur.com/a/lmLaTuO

R=dpapad@chromium.org
BUG=883049

Change-Id: Id13279e14673b53b79cb0ff31a72f0d305016c93
Reviewed-on: https://chromium-review.googlesource.com/c/1435966
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625967}

Comment 72 by bugdroid, Jan 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcfd409ca96868f629c231e49f2df839f94fb89d

commit fcfd409ca96868f629c231e49f2df839f94fb89d
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Jan 25 03:12:05 2019

WebUI Dark Mode: update cr-profile-avatar-selector selected border color

Screenshot: https://imgur.com/a/YdHSUYS

R=dpapad@chromium.org
BUG=883049

Change-Id: I8729d9cb995393946b80fa1656274d6c730060ea
Reviewed-on: https://chromium-review.googlesource.com/c/1436399
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625971}

Comment 73 by bugdroid, Jan 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64c49d18d47df41e963d1ef37b5c8137bb92862e

commit 64c49d18d47df41e963d1ef37b5c8137bb92862e
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Jan 25 03:48:45 2019

WebUI Dark Mode: clean up some cr-slider CSS var nits

R=aee@chromium.org
BUG=883049

Change-Id: Ibab66118c2f6e12def7941b43a38651d8dbba914
Reviewed-on: https://chromium-review.googlesource.com/c/1436189
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625981}

Comment 74 by dbeam@chromium.org, Jan 25

Labels: M-74

Comment 75 by bugdroid, Jan 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2563137e8c52e66afd1368361b769fc9ad5f113

commit e2563137e8c52e66afd1368361b769fc9ad5f113
Author: Dan Beam <dbeam@chromium.org>
Date: Sat Jan 26 01:56:46 2019

WebUI Dark Mode: fix various .svg url()s with optimize_webui = true

R=aee@chromium.org
BUG=883049

Change-Id: I59f447ca7e21e7b2e8db4f8686e0739e8e68eaf7
Reviewed-on: https://chromium-review.googlesource.com/c/1437579
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626303}

Comment 76 by bugdroid, Jan 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df60d14a6de9395e0f013b78eb880e9de376ffd7

commit df60d14a6de9395e0f013b78eb880e9de376ffd7
Author: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Date: Sat Jan 26 02:12:54 2019

Revert "WebUI Dark Mode: force user manager and print preview into light mode"

This reverts commit 340e60088b1bd792c87f09b483a69dad24ec5b3b.

Reason for revert: this was just on the off chance WebUI Dark Mode made it in M73.  It's probably not going to, but either way: no longer need this temporary change in.

Original change's description:
> WebUI Dark Mode: force user manager and print preview into light mode
> 
> This is in the unlikely event that dark mode actually makes it in 73.
> These UIs are not ready yet.
> 
> R=‚Äčdpapad@chromium.org
> BUG=883049
> 
> Change-Id: Iaa79feadd8d341c4b730a9a6598f42c756070613
> Reviewed-on: https://chromium-review.googlesource.com/c/1435517
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#625843}

TBR=dbeam@chromium.org,dpapad@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 883049
Change-Id: I31278716430d53b1181de4da5044d158aaf33473
Reviewed-on: https://chromium-review.googlesource.com/c/1437746
Reviewed-by: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626305}

Comment 77 by bugdroid, Jan 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce7a3265efb71f0d2bcd6e11c0063206b05db562

commit ce7a3265efb71f0d2bcd6e11c0063206b05db562
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Jan 30 04:30:18 2019

WebUI Dark Mode: fix offset, blur, and spread of ambient card shadows

R=dpapad@chromium.org
BUG=883049

Change-Id: Ib9385cef15b56c4b94babbd41d776d1b349fd6f5
Reviewed-on: https://chromium-review.googlesource.com/c/1444811
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627311}
[modify] https://crrev.com/ce7a3265efb71f0d2bcd6e11c0063206b05db562/ui/webui/resources/cr_elements/shared_vars_css.html

Comment 78 by dbeam@chromium.org, Jan 30

Blockedon: 926658

Comment 79 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efa82cdcaba24bb09fb75de527971bd92c8696b4

commit efa82cdcaba24bb09fb75de527971bd92c8696b4
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Feb 01 00:20:56 2019

WebUI Dark Mode: update toolbar background color (to 4% white)

Update all the loading shims to account for this (and simplify code).
Because prod code is bundled, we can just use --md-* vars from
md_colors.css directly, rather than continue duplicating them (yay!).

Drop toolbar bottom-border everywhere but in dev mode on extensions.
In dev mode, extensions should have bottom-border below both toolbar
and dev bar (and the loading shim should look accordingly as well).

Additionally, fix some wrong icon colors inside toolbar (i.e. search,
vertical more dots) and fix toolbar selection overlay bottom-border
color.

All of the changes in this CL are directly from Namrata.

Screenshots (light & dark): https://imgur.com/a/yB0Xl19

R=dpapad@chromium.org
BUG=883049,926937

Change-Id: I5b1ebc9d6130d2e899093602bf198cb407b46fdf
Reviewed-on: https://chromium-review.googlesource.com/c/1445238
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628163}
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/chrome/browser/resources/bookmarks/bookmarks.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/chrome/browser/resources/bookmarks/toolbar.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/chrome/browser/resources/downloads/downloads.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/chrome/browser/resources/downloads/toolbar.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/chrome/browser/resources/history/history.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/chrome/browser/resources/history/history_toolbar.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/chrome/browser/resources/md_extensions/extensions.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/chrome/browser/resources/md_extensions/toolbar.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/chrome/browser/resources/md_extensions/toolbar.js
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/chrome/browser/resources/reset_password/reset_password.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/chrome/browser/resources/settings/settings.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/ui/webui/resources/cr_elements/paper_button_style_css.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/ui/webui/resources/cr_elements/shared_vars_css.html
[modify] https://crrev.com/efa82cdcaba24bb09fb75de527971bd92c8696b4/ui/webui/resources/css/md_colors.css

Comment 80 by dbeam@chromium.org, Feb 2

Labels: OS-Chrome OS-Linux OS-Windows
this is coming to Mac first, but should eventually go everywhere

Comment 81 by dbeam@chromium.org, Feb 6

Blockedon: 926883

Comment 82 by dbeam@chromium.org, Feb 6

Blockedon: 926918

Comment 83 by bugdroid, Feb 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da87ed8b714cde5ae0a58c8a5b435800036083ba

commit da87ed8b714cde5ae0a58c8a5b435800036083ba
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Feb 06 19:31:19 2019

WebUI Dark Mode: fix some accidentally black text

R=hcarmona@chromium.org
BUG=883049

Change-Id: I0f2b4f97c130bbca75780bbcfccdd902f85956e4
Reviewed-on: https://chromium-review.googlesource.com/c/1455738
Auto-Submit: Dan Beam <dbeam@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629684}
[modify] https://crrev.com/da87ed8b714cde5ae0a58c8a5b435800036083ba/chrome/browser/resources/md_extensions/host_permissions_toggle_list.html

Comment 84 by bugdroid, Feb 7

Project Member

Sign in to add a comment