New issue
Advanced search Search tips

Issue 883020 link

Starred by 1 user
Status: Fixed
Owner:
jianli@chromium.org
Closed: Sep 14
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Offline indicator should reshow when user switches to other app and go back to Chrome

Project Member Reported by jianli@chromium.org, Sep 11 
Steps:
1) User has Chrome in foreground, becomes offline. We show indicator.
2) User switches to another app, or locks the screen. Later, they switch back to Chrome or unlock the screen.

Offline indicator should be reshown.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6851abbcd35c2f5f2c1750d2f052c32d6b0edced

commit 6851abbcd35c2f5f2c1750d2f052c32d6b0edced
Author: Jian Li <jianli@chromium.org>
Date: Tue Sep 11 23:16:05 2018

Reshow offline indicator when chrome activity resumes

Also shorten the time to wait for stable offline to 20s.

Bug:  883020 
Change-Id: If932810e0d4864fe00bd2fec980175086b43afbd
Reviewed-on: https://chromium-review.googlesource.com/1220049
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590527}
[modify] https://crrev.com/6851abbcd35c2f5f2c1750d2f052c32d6b0edced/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java
[modify] https://crrev.com/6851abbcd35c2f5f2c1750d2f052c32d6b0edced/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/TopSnackbarManager.java

Comment 2 by jianli@chromium.org, Sep 14

Labels: Merge-Request-70
Verified in 71.0.3552.0
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 14

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by benmason@chromium.org, Sep 14

Labels: -Hotlist-Merge-Review -Merge-Review-70 Merge-Approved-70
Approved for merge into 70, branch 3538.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 14

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e90950ea7fbaeaef83fe45180b45a1ae6225c56d

commit e90950ea7fbaeaef83fe45180b45a1ae6225c56d
Author: Jian Li <jianli@chromium.org>
Date: Fri Sep 14 18:34:10 2018

Merge M70: Reshow offline indicator when chrome activity resumes

Also shorten the time to wait for stable offline to 20s.

TBR=jianli@chromium.org

(cherry picked from commit 6851abbcd35c2f5f2c1750d2f052c32d6b0edced)

Bug:  883020 
Change-Id: If932810e0d4864fe00bd2fec980175086b43afbd
Reviewed-on: https://chromium-review.googlesource.com/1220049
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590527}
Reviewed-on: https://chromium-review.googlesource.com/1227177
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#414}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/e90950ea7fbaeaef83fe45180b45a1ae6225c56d/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java
[modify] https://crrev.com/e90950ea7fbaeaef83fe45180b45a1ae6225c56d/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/TopSnackbarManager.java

Comment 6 by jianli@chromium.org, Sep 14

Status: Fixed (was: Started)
►

Sign in to add a comment