New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 883011 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

[ios] M70 beta compile failing

Project Member Reported by justincohen@chromium.org, Sep 11

Issue description



See: https://uberchromegw.corp.google.com/i/official.ios/builders/ios/builds/2868

Log: https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.ios%2Fios%2F2868%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout



FAILED: obj/components/invalidation/impl/unit_tests/fcm_invalidation_service_unittest.o 
clang++ -MMD -MF obj/components/invalidation/impl/unit_tests/fcm_invalidation_service_unittest.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DCR_XCODE_VERSION=1000 -DCR_CLANG_REVISION=\"340925-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DNS_BLOCK_ASSERTIONS=1 -DWEBP_EXTERN=extern -DEXPAT_RELATIVE_PATH -DGTEST_API_= -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DGTEST_HAS_TR1_TUPLE=0 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DWEBRTC_IOS -DXML_STATIC -DABSL_ALLOCATOR_NOTHROW=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DUSE_REMOTE_TEST_SERVER -DUNIT_TEST -DNO_MAIN_THREAD_WRAPPING -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_SUPPORT_GPU=0 -I../.. -Igen -I../../third_party/libyuv/include -I../../third_party/libwebp/src -I../../third_party/webrtc_overrides -I../../testing/gtest/include -I../../third_party/libyuv/include -I../../third_party/usrsctp/usrsctplib -I../../third_party/webrtc -I../../third_party/googletest/custom -I../../third_party/googletest/src/googletest/include -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/webrtc_overrides -I../../testing/gtest/include -I../../third_party/webrtc -I../../third_party/webrtc_overrides -I../../third_party/webrtc -I../../third_party/expat/files/lib -I../../third_party/abseil-cpp -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/boringssl/src/include -I../../third_party/googletest/custom -I../../third_party/googletest/src/googlemock/include -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/modules/skottie/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fcolor-diagnostics -fmerge-all-constants -no-canonical-prefixes -arch arm64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wunguarded-availability -Wundeclared-selector -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Oz -fno-omit-frame-pointer -gdwarf-2 -isysroot /b/c/xcode_ios_10l232m.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.0.sdk -stdlib=libc++ -miphoneos-version-min=10.0 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-inconsistent-missing-override -std=c++14 -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -c ../../components/invalidation/impl/fcm_invalidation_service_unittest.cc -o obj/components/invalidation/impl/unit_tests/fcm_invalidation_service_unittest.o
../../components/invalidation/impl/fcm_invalidation_service_unittest.cc:75:11: error: no type named 'FakeInvalidator' in namespace 'syncer'; did you mean 'FCMFakeInvalidator'?
  syncer::FakeInvalidator* fake_invalidator_;  // Owned by the service.
  ~~~~~~~~^~~~~~~~~~~~~~~
          FCMFakeInvalidator
../../components/invalidation/impl/fcm_fake_invalidator.h:18:7: note: 'FCMFakeInvalidator' declared here
class FCMFakeInvalidator : public Invalidator {
      ^
1 error generated.


 
Labels: -Pri-3 ReleaseBlock-Beta M-70 Pri-1
Issue 882753 has been merged into this issue.
Owner: justincohen@chromium.org
Assigning to iOS sheriff. Let me know if that's not right.
Cc: tschumann@chromium.org
Status: Assigned (was: Untriaged)
tschumann@ any objection to me reverting crrev.com/c/1215203 until melandory@ is back?
Labels: Merge-Request-70
I've got a CL that fixes the issue: crrev.com/c/1220706.
Requesting merge to branch 3538.


Sorry for the troubles this created. I have to say I'm a bit surprised it took so long until the problem surfaced (guess our tooling can be improved). Will follow-up with melandory@ once she's back from vacation.

Thanks for investigating and fixing the problem!

thanks for fixing the issue, pavely@!
There's no way to verify this fix without merging it on branch first, correct?
I ran local build and components_unittests. It is not the issue on the main trunk, so verification there is not an option.
Labels: -Merge-Request-70 Merge-Approved-70
Ok approved.
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 12

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbbbccecbe22db770bafd4512bd041c4f5e21101

commit fbbbccecbe22db770bafd4512bd041c4f5e21101
Author: Pavel Yatsuk <pavely@google.com>
Date: Wed Sep 12 16:02:09 2018

Fix merge issue in fcm_invalidation_service_unittest.cc

Merge (crrev.com/c/1215203) of CL (crrev.com/c/1194032) didn't include
one change in fcm_invalidation_service_unittest.cc which caused build
failures in components_unittests.

Fixing it on branch 3538.

BUG= 883011 

Change-Id: I73a78b136d8a97c6c1dcf194dd307d6f8709986e
Reviewed-on: https://chromium-review.googlesource.com/1220706
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#329}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/fbbbccecbe22db770bafd4512bd041c4f5e21101/components/invalidation/impl/fcm_invalidation_service_unittest.cc

Sign in to add a comment