New issue
Advanced search Search tips

Issue 883010 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Sep 21
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Network servicification of NQE in content

Project Member Reported by tbansal@chromium.org, Sep 11 
Network Quality Estimator (NQE) is being used in content to send network quality change notifications from browser to the renderer process. These are eventually consumed by Blink as well as exposed to Web via NetInfo (https://wicg.github.io/netinfo/).

The current pipeline listens to the network quality estimator (NQE) class which is not going to work with network servicification. 

We need to servicify this pipeline. Specifically, replace NQE in content by Network Quality Tracker (NQT). The latter works with network servicification enabled as well.

Comment 1 by tbansal@chromium.org, Sep 11

Labels: Proj-Servicification-Stable

Comment 2 by jam@chromium.org, Sep 19 

Hi, just checking this being worked on? Thanks

Comment 3 by tbansal@chromium.org, Sep 19 

yup, under review with mmenke.

Comment 4 by tbansal@chromium.org, Sep 19 

*CL* under review.

Comment 5 by jam@chromium.org, Sep 19 

great, thanks!
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86b3922284f50beeafa3075ed4d552b2af03114c

commit 86b3922284f50beeafa3075ed4d552b2af03114c
Author: Tarun Bansal <tbansal@chromium.org>
Date: Fri Sep 21 02:07:32 2018

Network servicification of NQE in content.

Servicify Network Quality Estimator (NQE) in content. This CL
replaces NQE APIs by Network Quality Tracker (NQT). The
latter works with network servicification enabled as well.

The NQE/NQT APIs in content are used to send network quality change
notifications to the renderer process. These are eventually
consumed by Blink as well as exposed to Web via NetInfo.

This CL also adds a Chrome browser test for the NetInfo API.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ib8c0f9b1742d3c1eb3dbefe8d891c06c4e986492
Bug:  883010 
Reviewed-on: https://chromium-review.googlesource.com/1214603
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593051}
[modify] https://crrev.com/86b3922284f50beeafa3075ed4d552b2af03114c/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/86b3922284f50beeafa3075ed4d552b2af03114c/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/86b3922284f50beeafa3075ed4d552b2af03114c/chrome/browser/io_thread.cc
[modify] https://crrev.com/86b3922284f50beeafa3075ed4d552b2af03114c/chrome/browser/io_thread.h
[modify] https://crrev.com/86b3922284f50beeafa3075ed4d552b2af03114c/chrome/browser/net/OWNERS
[modify] https://crrev.com/86b3922284f50beeafa3075ed4d552b2af03114c/chrome/browser/net/netinfo_network_quality_estimator_holdback_browsertest.cc
[add] https://crrev.com/86b3922284f50beeafa3075ed4d552b2af03114c/chrome/browser/net/network_quality_netinfo_browsertest.cc
[modify] https://crrev.com/86b3922284f50beeafa3075ed4d552b2af03114c/chrome/test/BUILD.gn
[modify] https://crrev.com/86b3922284f50beeafa3075ed4d552b2af03114c/content/browser/net/network_quality_observer_impl.cc
[modify] https://crrev.com/86b3922284f50beeafa3075ed4d552b2af03114c/content/browser/net/network_quality_observer_impl.h
[modify] https://crrev.com/86b3922284f50beeafa3075ed4d552b2af03114c/content/browser/net/network_quality_observer_impl_unittest.cc
[modify] https://crrev.com/86b3922284f50beeafa3075ed4d552b2af03114c/content/browser/net_info_browsertest.cc
[modify] https://crrev.com/86b3922284f50beeafa3075ed4d552b2af03114c/content/public/browser/network_quality_observer_factory.h
[modify] https://crrev.com/86b3922284f50beeafa3075ed4d552b2af03114c/services/network/public/cpp/network_quality_tracker.cc
[modify] https://crrev.com/86b3922284f50beeafa3075ed4d552b2af03114c/services/network/public/cpp/network_quality_tracker.h

Comment 7 by tbansal@chromium.org, Sep 21

Status: Fixed (was: Started)

Comment 8 by tbansal@chromium.org, Sep 21

Components: Internals>Network>NetInfo
►

Sign in to add a comment