New issue
Advanced search Search tips

Issue 883001 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Add support for projects with any Code-Review/Commit-Queue label values to Auto-Submit

Project Member Reported by jkop@chromium.org, Sep 11

Issue description

This will make the Auto-Submit feature usable by projects that do not use Chromium's CQ+2 and CR+1 max label values. Eg: CrOS and Fuchsia.

 
Blocking: 631551
Components: Infra>Client>ChromeOS Infra>Codereview>Gerrit
Labels: -Pri-1 Pri-2
Summary: auto-submit for chromiumos repos (was: auto-submit for infra/infra, build, depot_tools, luci-go repos)
Owner: rmis...@google.com
Status: Assigned
Blocking: -631551
Summary: Handle chromiumos votes in auto-submit (was: auto-submit for chromiumos repos)
Removing the blocking https://bugs.chromium.org/p/chromium/issues/detail?id=631551 part because I intended that to be only for the Chromium repos which is why I did not support other vote values for it.

Which are all the chromium OS repos?

Also renaming this to add support to auto-submit for chromiumos repos. Actually activating that for those projects configs will have to be done by somebody else.
Summary: Add support for projects with any Code-Review/Commit-Queue label values to Auto-Submit (was: Handle chromiumos votes in auto-submit)
Description: Show this description
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/f0b7d8770eb89bb5213606079d272b45039bf4a5

commit f0b7d8770eb89bb5213606079d272b45039bf4a5
Author: Ravi Mistry <rmistry@google.com>
Date: Tue Oct 16 13:00:09 2018

Add support for projects with any Code-Review/Commit-Queue label values to Auto-Submit

Bug:  883001 
Change-Id: I1d1e29e221ba6ed5b7885a75d36341931774df48

[modify] https://crrev.com/f0b7d8770eb89bb5213606079d272b45039bf4a5/src/main/resources/static/chromium-behavior.html

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/8accf52ee8b4ddec45acb05800c745acdbd0ff1c

commit 8accf52ee8b4ddec45acb05800c745acdbd0ff1c
Author: Ravi Mistry <rmistry@google.com>
Date: Thu Oct 18 13:09:34 2018

Remove hardcoded Code-Review label value

Bug:  883001 , 895835 
Change-Id: I310e958eb16caeda86c7080b66cbf445b3cbd2d8
[modify] https://crrev.com/8accf52ee8b4ddec45acb05800c745acdbd0ff1c/src/main/resources/static/chromium-behavior.html

Cc: tandrii@chromium.org
Status: Fixed (was: Assigned)
All my changes are now live in production.

We can now try enabling Auto-Submit for CrOS projects and see if it works.
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/2860215719e8f10204b3de9e6961453425f83630

commit 2860215719e8f10204b3de9e6961453425f83630
Author: Ravi Mistry <rmistry@google.com>
Date: Thu Nov 08 16:26:44 2018

Add support for projects with any CR/CQ label values to chromium-behavior plugin

Bug:  883001 
Change-Id: I4fbcd44a944ebb27169a914a88d133417c148fcc

[modify] https://crrev.com/2860215719e8f10204b3de9e6961453425f83630/src/main/resources/static/chromium-behavior.html

Sign in to add a comment