Shelf buttons in overflow don't scale back down after long press is over |
||||||||||||||||||||||||||||||
Issue descriptionchrome:71.0.3550.0 What steps will reproduce the problem? (1) Open "..." button on shelf to open overflow of shelf. (2) Long press one shelf icon on the overflow shelf until the context menu is shown. What is the expected result? The shelf icon that be scaled up a little bit after long press should be scaled back to its previous size after release the finger. What happens instead? The shelf icon is still in scaled-up state after release the finger.
,
Sep 12
,
Sep 13
Thank you! Hmm, I'm not quite sure what the problem is here. Attaching screenshots of what I see for the various steps. Am I not doing what you suggest? Or is this already fixed? Assigning to you to clarify :-) Thanks!
,
Sep 13
,
Sep 13
Oh, you mean the slight scaling effect that happens to the icon when long-pressing it? I can't seem to find a way to make it "stuck" in the "zoomed in" state. Could you perhaps try again and let me know if your repro steps need updating? Thanks!
,
Sep 13
,
Sep 13
Ah, I see now. Thanks for taking the time to make the video.
,
Sep 13
Happy to help consult on this one for whoever fixes it, I'm gardening and doing merges so I'm not a good candidate to fix it fast. The icons normally do not scale down until the finger has been released. I wonder if we are getting that ET_GESTURE_END event?
,
Sep 13
(also making P-1 because imo it would be bad for this to happen on devices which easily show overflow, like dru.)
,
Sep 13
Not sure it should be P1... Sure overflow can be common, but it happens when long-pressing, and it's still a pretty transient state. Anyway, I'll try to fix it regardless :-)
,
Sep 13
,
Sep 18
I'd love to get this done for M-70 (so this is still on my list), but realistically I think it will most likely need to wait for M-71.
,
Sep 20
It seems like this may only happen in 71 anyway. I'm trying to repro on 70.0.3538.16 and it doesn't repro.
,
Sep 20
I tried on 70.0.3538.22 and it repros. :/ https://photos.app.goo.gl/k45GtrwEfCiZuBN17
,
Sep 20
This might also cause the shelf buttons can't be dragged from overflow shelf to main shelf after context menu is shown.
,
Oct 16
,
Nov 20
,
Nov 20
FYI fix sent as CL 1343659
,
Nov 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa530e337014a0995717927bf99c6586c6b7b3a4 commit fa530e337014a0995717927bf99c6586c6b7b3a4 Author: Manu Cornet <manucornet@chromium.org> Date: Thu Nov 22 14:37:15 2018 CrOS shelf: more fine grained forwarding of gestures from overflow Currently, most gestures on the overflow shelf are completely ignored. This causes (among other things) the two bugs linked from this CL because gestures trying to reorder icons, or after a long press event, are ignored. The main reason for the special casing is that we don't want gestures on the overflow shelf to cause showing the app list, or to drag the shelf itself when it's an autohide shelf. However, ignoring all gestures is overkill. This CL handles gestures in a more fine grained way: * The app list cannot be shown by swiping up from the shelf when the overflow shelf is shown. The change here is that one could initially swipe up from the main shelf even when the overflow shelf was shown. Now the overflow shelf needs to be hidden first. The previous behavior could arguably be seen as a bug because one could get a full screen app list while the overflow menu was still being shown, which looked quite strange. * The shelf cannot be dragged up or down (in the case of an autohide shelf) when the overflow shelf is shown. Previously, one could drag the shelf while overflow was open (just not by performing the gesture on the overflow shelf itself). This resulted in behaviors where the whole "shelf + overflow" could be dragged up or down. Now, the overflow shelf will be dismissed first. One could argue either way, but I would consider the change a good change. * All other gestures are handled in the overflow shelf in the same way as the main shelf. Bug: 882991 , 905121 Change-Id: I9269b9a0943f4aa39aa26d4d339cbbfa80b51135 Reviewed-on: https://chromium-review.googlesource.com/c/1343659 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by: Mitsuru Oshima (OOO till 11/26) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#610409} [modify] https://crrev.com/fa530e337014a0995717927bf99c6586c6b7b3a4/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/fa530e337014a0995717927bf99c6586c6b7b3a4/ash/shelf/shelf_view.cc [modify] https://crrev.com/fa530e337014a0995717927bf99c6586c6b7b3a4/ash/shelf/shelf_view_unittest.cc
,
Nov 22
,
Dec 5
Reopen this issue since I can still see the issue at 73.0.3631.0
,
Dec 12
,
Dec 12
FYI sent out fix in CL 1373809
,
Dec 12
Removing Google restrict label (don't see a good reason not to have this be public)
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9069c243f397437a4f40f631c72150fd5e33bac1 commit 9069c243f397437a4f40f631c72150fd5e33bac1 Author: Manu Cornet <manucornet@chromium.org> Date: Wed Dec 12 18:56:06 2018 CrOS Shelf: For overflow, only forward to bubble events it can handle Bug: 882991 Change-Id: I952c5e9ed4d2153b50fb7cfb2bc15b4f7557b9fb Reviewed-on: https://chromium-review.googlesource.com/c/1373809 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#615982} [modify] https://crrev.com/9069c243f397437a4f40f631c72150fd5e33bac1/ash/shelf/overflow_bubble_view.cc [modify] https://crrev.com/9069c243f397437a4f40f631c72150fd5e33bac1/ash/shelf/overflow_bubble_view.h [modify] https://crrev.com/9069c243f397437a4f40f631c72150fd5e33bac1/ash/shelf/shelf_view.cc
,
Dec 12
,
Dec 13
,
Dec 13
Reopening until the 72 merge is complete (this simplifies release readiness tracking)
,
Dec 13
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c2017192f4448b979279fe94d10a89ddb7abd19 commit 4c2017192f4448b979279fe94d10a89ddb7abd19 Author: Manu Cornet <manucornet@chromium.org> Date: Fri Dec 14 13:38:39 2018 CrOS Shelf: For overflow, only forward to bubble events it can handle Bug: 882991 Change-Id: I952c5e9ed4d2153b50fb7cfb2bc15b4f7557b9fb Reviewed-on: https://chromium-review.googlesource.com/c/1373809 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615982}(cherry picked from commit 9069c243f397437a4f40f631c72150fd5e33bac1) Reviewed-on: https://chromium-review.googlesource.com/c/1375177 Reviewed-by: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#355} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/4c2017192f4448b979279fe94d10a89ddb7abd19/ash/shelf/overflow_bubble_view.cc [modify] https://crrev.com/4c2017192f4448b979279fe94d10a89ddb7abd19/ash/shelf/overflow_bubble_view.h [modify] https://crrev.com/4c2017192f4448b979279fe94d10a89ddb7abd19/ash/shelf/shelf_view.cc
,
Dec 14
Thanks Vlad. Should be all good now.
,
Dec 19
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 4c2017192f4448b979279fe94d10a89ddb7abd19 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c2017192f4448b979279fe94d10a89ddb7abd19 Commit: 4c2017192f4448b979279fe94d10a89ddb7abd19 Author: manucornet@chromium.org Commiter: manucornet@chromium.org Date: 2018-12-14 13:38:39 +0000 UTC CrOS Shelf: For overflow, only forward to bubble events it can handle Bug: 882991 Change-Id: I952c5e9ed4d2153b50fb7cfb2bc15b4f7557b9fb Reviewed-on: https://chromium-review.googlesource.com/c/1373809 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615982}(cherry picked from commit 9069c243f397437a4f40f631c72150fd5e33bac1) Reviewed-on: https://chromium-review.googlesource.com/c/1375177 Reviewed-by: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#355} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||||||
Comment 1 by minch@chromium.org
, Sep 11