Link to CIPD UI https://chrome-infra-packages.appspot.com from swarming task details |
|||||||
Issue descriptionA task usually resolves and installs a bunch of CIPD packages. Linking to exact package instance that was installed will save a bunch of clicks during debug. Repro: 1. visit https://chromium-swarm.appspot.com/task?id=3fe250d2d8491b10&refresh=10&request_detail=true&show_raw=1 2. click "more details" 3. Scroll down to CIPD packages https://screenshot.googleplex.com/PGudFOPCsTp
,
Sep 11
That's a good idea.
,
Sep 16
,
Sep 28
I'd like to be able to do this in a generic way, kind of how we link in the source repos. I.e. I need to know the infra server (which is already passed in) and some rule for properly linking to https://chrome-infra-packages.appspot.com/p/infra/python/cpython/windows-amd64/+/ for a CIPD package infra/python/cpython/windows-amd64 If we don't mind a chromium-specific fix, then I can have this linkified in short order. A more generic approach would likely involve a proto update.
,
Sep 28
The service URL is in the /request as cipd_inputs/client_package/server in the properties, so one per task slice. So no need to hard code the URL.
,
Sep 28
The same transform (server + "/p/" + package) can be assumed for all potential CIPD set-ups?
,
Sep 28
yes and there's only one
,
Sep 28
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/39af13de7cc07029cf8011c3028d39693361c3aa commit 39af13de7cc07029cf8011c3028d39693361c3aa Author: Kevin Lubick <kjlubick@google.com> Date: Fri Sep 28 16:44:49 2018 Add CIPD links to task-page UI Also add in search icons to task-list and bot-list. Bug: 882990 , 866951 Change-Id: I67ed1cb05eb3be89a189ab57bed0d5996b81c187 Reviewed-on: https://chromium-review.googlesource.com/1251663 Commit-Queue: Kevin Lubick <kjlubick@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/39af13de7cc07029cf8011c3028d39693361c3aa/appengine/swarming/ui/build/elements.html [modify] https://crrev.com/39af13de7cc07029cf8011c3028d39693361c3aa/appengine/swarming/ui/res/imp/botlist/bot-filters.html [modify] https://crrev.com/39af13de7cc07029cf8011c3028d39693361c3aa/appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html [modify] https://crrev.com/39af13de7cc07029cf8011c3028d39693361c3aa/appengine/swarming/ui/res/imp/tasklist/task-filters.html [modify] https://crrev.com/39af13de7cc07029cf8011c3028d39693361c3aa/appengine/swarming/ui/res/imp/taskpage/task-page.html
,
Oct 9
This change is now live on prod with 3809-a31bbe1. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tandrii@chromium.org
, Sep 11