New issue
Advanced search Search tips

Issue 882983 link

Starred by 1 user
Status: Fixed
Owner:
sergeyu@chromium.org
Closed: Oct 6
Cc:
solenberg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

Fuchsia: audio fails to play on youtube

Project Member Reported by sergeyu@chromium.org, Sep 11 
1. Open youtube.com
2. Play a video
3. Observe that audio plays for the ad, but not for the video itself and it doesn't play even after navigating to a different video.

I couldn't reproduce this issue when opening a page with 3 <audio> elements.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e7c1b59c87f52bc7e46cf7a92e51247c3e54d1b

commit 8e7c1b59c87f52bc7e46cf7a92e51247c3e54d1b
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Sep 14 18:34:23 2018

Fix reference_time calculation in AudioOutputStreamFuchsia

AudioOutputStreamFuchsia was relying on AudioOut::Play() to calculate
stream reference time. When the stream was previously paused Play()
doesn't take into account the current media position, as result
reference_time wasn't calculated correctly (see MTWN-164). Updated the
code to calculate reference_time_ explicitly instead of relying on
AudioOut::Play().

Also added DiscardAllPackets() call in Stop() to discard all buffered
data to avoid playing it when the stream is restarted.

Bug:  882983 
Change-Id: I216fd41bfdb3479ea4c8db6523c7e66ce91552cf
Reviewed-on: https://chromium-review.googlesource.com/1220704
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591409}
[modify] https://crrev.com/8e7c1b59c87f52bc7e46cf7a92e51247c3e54d1b/media/audio/fuchsia/audio_output_stream_fuchsia.cc

Comment 2 by sergeyu@chromium.org, Oct 6

Status: Fixed (was: Started)
►

Sign in to add a comment