[BGPT] Some virtual/threaded pinch zoom tests are flaky |
|||
Issue descriptionSample failures: https://test-results.appspot.com/data/layout_results/linux-blink-gen-property-trees/451/layout-test-results/results.html https://test-results.appspot.com/data/layout_results/linux-blink-gen-property-trees/446/layout-test-results/results.html FAIL Touchpad pinch can be prevented by wheel handlers assert_approx_equals: expected 2 +/- 0.001 but got 1.1382160186767578 Layout tests: virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchpad.html virtual/threaded/fast/events/pinch/gesture-pinch-zoom-prevent-in-handler.html virtual/threaded/fast/events/pinch/scroll-visual-viewport-send-boundary-events.html
,
Sep 13
Sahel, would you be able to look at these tests, particularly virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchpad.html? This is failing when run with --additional-driver-flag=--enable-blink-gen-property-trees.
,
Sep 14
Sure, I will investigate.
,
Yesterday
(39 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08aed290f42041ab29fc82ef6e127c33e2871b47 commit 08aed290f42041ab29fc82ef6e127c33e2871b47 Author: Kevin McNee <mcnee@chromium.org> Date: Mon Jan 21 18:02:07 2019 Address flaky desktop touchscreen synthetic pinch zoom gesture tests The lenient versions of these tests were missing a call to waitForCompositorCommit after the gesture which the full versions of the tests have. We also clean up the TestExpectations for these synthetic_gestures tests as some of the entries appear to no longer be an issue. Bug: 922508, 787615 , 891427, 882975 Change-Id: Idf084b3651e74bbbfc337a73ba8223aa8db8d3a3 Reviewed-on: https://chromium-review.googlesource.com/c/1418522 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#624613} [modify] https://crrev.com/08aed290f42041ab29fc82ef6e127c33e2871b47/third_party/blink/web_tests/TestExpectations [modify] https://crrev.com/08aed290f42041ab29fc82ef6e127c33e2871b47/third_party/blink/web_tests/virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture.js |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Sep 11