New issue
Advanced search Search tips

Issue 882973 link

Starred by 1 user
Status: Fixed
Owner:
pdr@chromium.org
Closed: Jan 10
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 836886



Sign in to add a comment

[BGPT] http/tests/devtools/layers/layer-tree-model.js fails

Project Member Reported by wangxianzhu@chromium.org, Sep 11 
Sample failure: https://test-results.appspot.com/data/layout_results/linux-blink-gen-property-trees/451/layout-test-results/results.html

--- /b/s/w/iothgQeC/layout-test-results/http/tests/devtools/layers/layer-tree-model-expected.txt
+++ /b/s/w/iothgQeC/layout-test-results/http/tests/devtools/layers/layer-tree-model-actual.txt
@@ -1,35 +1,32 @@
 Tests general layer tree model functionality
 Initial layer tree
-#document (7)
-    iframe#frame (8)
-        #document 200x200 (9)
-            #document 200x200 (10)
-                div#subframe1 80x80 (11)
-    div#a 200x200 (8)
-        div#b1 100x150 (9)
-        div#b2 110x140 (9)
-            div#c 90x100 (10)
-        div#b3 110x140 (9)
+#document (6)
+    iframe#frame (7)
+        #document 200x200 (8)
+            div#subframe1 80x80 (9)
+    div#a 200x200 (7)
+        div#b1 100x150 (8)
+        div#b2 110x140 (8)
+            div#c 90x100 (9)
+        div#b3 110x140 (8)
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eee601005702561b7d73cc2e7b93ac311071a5b

commit 6eee601005702561b7d73cc2e7b93ac311071a5b
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Sep 11 19:46:59 2018

[BGPT] Update FlagExpectations/enable-blink-gen-property-trees

Bug:  882973 , 882974 ,882975
Change-Id: If63c4f260a11360f2044dc94a14fea20c2133ac4
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees
Reviewed-on: https://chromium-review.googlesource.com/1220467
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590443}
[modify] https://crrev.com/6eee601005702561b7d73cc2e7b93ac311071a5b/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/536eee6451098edd9587785643ae3a19a687dc8d

commit 536eee6451098edd9587785643ae3a19a687dc8d
Author: Philip Rogers <pdr@chromium.org>
Date: Thu Jan 10 19:21:32 2019

[BlinkGenPropertyTrees] Rebaseline layer-tree-model.js

This patch rebaselines http/tests/devtools/layers/layer-tree-model.js.
BGPT can produce slightly different layer trees due to the ancestor
clipping layer not being present.

Bug:  882973 
Change-Id: If078bb5e194bfe5494d7d7c517c70d1a9a89b374
Reviewed-on: https://chromium-review.googlesource.com/c/1405274
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621695}
[modify] https://crrev.com/536eee6451098edd9587785643ae3a19a687dc8d/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/536eee6451098edd9587785643ae3a19a687dc8d/third_party/blink/web_tests/http/tests/devtools/layers/layer-tree-model-expected.txt

Comment 3 by pdr@chromium.org, Jan 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment