zentaro@chromium.org

Unclear if this is related the crash we just fixed.

Also looks like this came from an aarch64 device, so try to repro on eg. Kevin.

The instant I hit the Add Network Share button, Chrome crashes. I get as far as the screenshot. 

Deleted: Screenshot 2018-09-12 at 8.25.44 AM.png 15.6 KB

	Screenshot 2018-09-12 at 8.25.44 AM.png 15.6 KB View Download

With today's update, I get a little bit further. I now get the dialog to enter the share information. No chance to enter any information as the interface freezes and Chrome crashes. smb-native
Sent a feedback report a few minutes ago with this issue number

Updated info 
11058.0.0 (Official Build) canary-channel elm
Version 71.0.3544.0 (Official Build) canary (32-bit)

Unable to repro on 11056- Chrome hasn't updated from 3544 in almost a week, let's see if this goes away once a build with an updated Chrome hits canary

I can confirm that this behaviour is reproducable on elm in the current dev channel (11021.13.0 70.0.3538.16) as well as in the previous where smb still had to be enabled via flag.
It is not the mounting with empty url bug as i can't even enter or click anything before it crashes.

I had a bug at the beginning of August that didn't get attention because it wasn't widespread.  Issue 870816  and  Issue 872394 . There are other issues that got fixed on my platform that made their way through to beta. Trying something on one or two platforms does not confirm a fix. 

We initially weren't able to repro on Elm. But we found that it repro's only when the only network interface is WiFi, and we typically also have ethernet connected while debugging.

But we have repro'd on Elm and Kevin now, but no repro on Dru which is also aarch64.

Thanks for the update. 

We found the bug. Those devices don't identify their WiFi interface correctly (crbug.com/884267), which exposed an underlying bug when there are "no" valid interfaces.

So there's one fix for the crash, but NetBIOS discovery won't work since it thinks there are no interfaces. Then another fix to either fix the identification of the network interface or find a workaround.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34d52351bdeb7429ecc53a3965b8524588dc19ab

commit 34d52351bdeb7429ecc53a3965b8524588dc19ab
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Sep 14 19:27:53 2018

Do not start discover timer if there are no valid interfaces

Previously, if there were no valid NetworkInterfaces we would exit out of
NetBios discovery, but the discovery timer would still be set causing a
moved-from callback to be run twice.

The crash was especially subtle becuase it required having no valid
network interfaces, which is uncommon because both Wifi and Ethernet are
valid interfaces.

Bug:  chromium:882972 
Test: verified manually on Elm device
Change-Id: I2e7a28aded718845a08669f464b60bba2bbc6174
Reviewed-on: https://chromium-review.googlesource.com/1226364
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591433}
[modify] https://crrev.com/34d52351bdeb7429ecc53a3965b8524588dc19ab/chrome/browser/chromeos/smb_client/discovery/netbios_host_locator.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81b796df73efce260a9258f45e3c4f1b7a4c3b0d

commit 81b796df73efce260a9258f45e3c4f1b7a4c3b0d
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Sep 14 22:27:27 2018

Do not start discover timer if there are no valid interfaces

Previously, if there were no valid NetworkInterfaces we would exit out of
NetBios discovery, but the discovery timer would still be set causing a
moved-from callback to be run twice.

The crash was especially subtle becuase it required having no valid
network interfaces, which is uncommon because both Wifi and Ethernet are
valid interfaces.

Bug:  chromium:882972 
Test: verified manually on Elm device
Change-Id: I2e7a28aded718845a08669f464b60bba2bbc6174
Reviewed-on: https://chromium-review.googlesource.com/1226364
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591433}(cherry picked from commit 34d52351bdeb7429ecc53a3965b8524588dc19ab)
Reviewed-on: https://chromium-review.googlesource.com/1227404
Cr-Commit-Position: refs/branch-heads/3538@{#429}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/81b796df73efce260a9258f45e3c4f1b7a4c3b0d/chrome/browser/chromeos/smb_client/discovery/netbios_host_locator.cc

Still crashes so I will assume that the fix did not make it to today's update.
11068.0.0
71.0.3552.6

Still crashes. 

71.0.3552.
Platform
11071.0.0 (Official Build) canary-channel elm
Firmware
Google_Elm.8438.140.0
Channel
Currently on canary

I have verified that can plug in ethernet and create the share. Once unplugged the share is available over WiFi. If I then try another share unplugged, I crash again.

Hey David-

The first build with the change will be Chrome 71.0.3553. Please reopen if it is still crashing once a build with 3553 is out. 

Thanks!

Thanks for the update.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c1387711dbd0d5f0495c07d91942f680db2f729

commit 4c1387711dbd0d5f0495c07d91942f680db2f729
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Sep 17 19:47:15 2018

Use mlan for host discovery

This change is a workaround to support NetBios Share Discovery of
Network File Shares on devices that do not identify their wireless
interface properly such as Kevin and Elm.

Test: verified manually on Elm
Bug:  chromium:882972 
Change-Id: Ic904ae87cbf91eb203dbc90a891d8b4f13181698
Reviewed-on: https://chromium-review.googlesource.com/1227302
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591789}
[modify] https://crrev.com/4c1387711dbd0d5f0495c07d91942f680db2f729/chrome/browser/chromeos/smb_client/discovery/netbios_host_locator.cc

Can confirm the fix in latest Chrome 71.0.3554.0 on ELM 11078.0.0

Also already in 70.0.3538.22 on elm. Thanks, smb shares work now.