Shelf is not auto-hidden after drag the maximized browser window from top. |
|||
Issue descriptionWhat steps will reproduce the problem? (1) Open browser window in tablet mode and keep only browser window is opened. (2) Set shelf to "auto-hide" in tablet mode. (3) Drag the maximized browser window from top with a small distance. (3) Release the drag. What is the expected result? The maximized browser window should restore back to maximized and shelf should be auto-hidden. What happens instead? Browser window restores back to maximized but shelf is still visible.
,
Sep 11
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e63f179c52700df6ce42e2c381d471864d95ff06 commit e63f179c52700df6ce42e2c381d471864d95ff06 Author: Min Chen <minch@google.com> Date: Tue Sep 11 23:32:13 2018 Update shelf visibility in ~TabletModeWindowDragDelegate. Added UpdateShelfVisibility in ~TabletModeWindowDragDelegate to keep shelf in correct state after drag a window from top. Most of the cases shelf can achieve a correct state after drag except for dragging a browser window from top. The problem is that we delete drag details in EndingForDraggingWindow for app windows but we can't do the same for browser window. Then ShelfLayoutManager::IsDraggingWindowFromTopOrCaptionArea will drop into wrong condition in this case, which will cause the shelf into a wrong state at the end of drag. Tried to UpdateShelfVisibility again in ~TabletModeWindowDragDelegate when drag details has already been deleted for all the window drags. Bug: 882962 Change-Id: I6915bcfd7ee1890d40ca5d422c913552a487daf1 Reviewed-on: https://chromium-review.googlesource.com/1219934 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#590529} [modify] https://crrev.com/e63f179c52700df6ce42e2c381d471864d95ff06/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.cc
,
Sep 11
|
|||
►
Sign in to add a comment |
|||
Comment 1 by minch@chromium.org
, Sep 11Labels: -Pri-1 -M-70 Pri-2
Summary: Shelf is not auto-hidden after drag the maximized browser window from top. (was: Update auto-hide shelf visibility after drag a window from top)