New issue
Advanced search Search tips

Issue 882944 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Chrome should ignore the value of old Autofill policy if either of the new Autofill policies are set

Project Member Reported by mahmadi@chromium.org, Sep 11

Issue description

Currently Chrome disables the new fine-grained Autofill prefs if the deprecated master pref is disabled by policy. This behavior should only happen if none of the new prefs are disabled by Policy as outlined in the migration plan for the Admin Console:

https://docs.google.com/document/d/1N87KhLvA8swjjxNJBE8Z90Wzs1Y_FkPavW1ehEcM8LU
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f832774e615310e55c05e33af5c4b608c2d4b116

commit f832774e615310e55c05e33af5c4b608c2d4b116
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Sep 13 16:44:43 2018

[AF] Ignores the old Autofill policy if any of the new policies are set

Bug:  882944 
Change-Id: Ibef68b3c956f3a508ecc7eeb3cdfb86572fb4d38
Reviewed-on: https://chromium-review.googlesource.com/1220735
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591042}
[modify] https://crrev.com/f832774e615310e55c05e33af5c4b608c2d4b116/components/autofill/core/browser/autofill_policy_handler.cc
[modify] https://crrev.com/f832774e615310e55c05e33af5c4b608c2d4b116/components/autofill/core/browser/autofill_policy_handler_unittest.cc

Labels: Merge-Request-70
Status: Fixed (was: Started)
There's no good (or easy) way to verify this fix on Canary as it requires the Admin Console to contain the new policies which doesn't yet. 
To note, there's a tool that allows testing policies in such cases: https://sites.google.com/a/google.com/chrome-enterprise-new/faq/using-yaps . Test engineers should be familiar with it.
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 13

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Approving merge for M70. Branch:3538
Can we get verification on Canary by the test team using the tool recommended in c#4?
Components: Enterprise
I was able to verify this on M-71 (11074.0.0, 71.0.3552.6) using YAPS.

Test scenario #1:
AutoFillEnabled=true
AutofillCreditCardEnabled=false
AutofillAddressEnabled=false

Test scenario #2:
AutoFillEnabled=false
AutofillCreditCardEnabled=true
AutofillAddressEnabled=true

Test scenario #3:
AutoFillEnabled=false
AutofillCreditCardEnabled=true
AutofillAddressEnabled=not set

In all scenarios Chrome ignores the old Autofill policy if any of the new policies are set.

Please let me know if you want me to test some different scenarios. I'll verify it again when it will be merged to M-70.
Status: Verified (was: Fixed)
Thank you.
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 18

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/351aa6de52548db41aafaff7b19105ac1acef503

commit 351aa6de52548db41aafaff7b19105ac1acef503
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Sep 18 15:28:43 2018

[AF] Ignores the old Autofill policy if any of the new policies are set

Bug:  882944 
Change-Id: Ibef68b3c956f3a508ecc7eeb3cdfb86572fb4d38
Reviewed-on: https://chromium-review.googlesource.com/1220735
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591042}(cherry picked from commit f832774e615310e55c05e33af5c4b608c2d4b116)
Reviewed-on: https://chromium-review.googlesource.com/1230443
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#492}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/351aa6de52548db41aafaff7b19105ac1acef503/components/autofill/core/browser/autofill_policy_handler.cc
[modify] https://crrev.com/351aa6de52548db41aafaff7b19105ac1acef503/components/autofill/core/browser/autofill_policy_handler_unittest.cc

Sign in to add a comment