New issue
Advanced search Search tips

Issue 882939 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 20
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

[animation worklet] Throw exception when trying to play invalid worklet animations

Project Member Reported by yigu@chromium.org, Sep 11

Issue description

Currently we are printing out a console message. Rather, an exception should be thrown.
 
Labels: -Type-Bug Type-Task
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1310529d2e7817d7696bb8cac0c52935751d60c

commit f1310529d2e7817d7696bb8cac0c52935751d60c
Author: Yi Gu <yigu@chromium.org>
Date: Thu Sep 20 20:10:24 2018

Throw exception upon trying to play invalid worklet animations

Currently we are printing out a console message upon trying to play an
invalid worklet animation, e.g. no-keyframe effect. Rather, an exception
should be thrown.

Note that regular animations accept effects without any keyframes, but
it currently does not make much sense in our implementation of worklet
animation.

It's a little bit strict to throw ATM, but once our implementation is
able to support it we can remove this exception.

Bug:  882939 
Change-Id: Ia63b67b70adeb132f5df2c8679935551ec3ac1d7
Reviewed-on: https://chromium-review.googlesource.com/1225091
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592921}
[add] https://crrev.com/f1310529d2e7817d7696bb8cac0c52935751d60c/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/worklet-animation-with-invalid-effect.html
[modify] https://crrev.com/f1310529d2e7817d7696bb8cac0c52935751d60c/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc
[modify] https://crrev.com/f1310529d2e7817d7696bb8cac0c52935751d60c/third_party/blink/renderer/modules/animationworklet/worklet_animation.h
[modify] https://crrev.com/f1310529d2e7817d7696bb8cac0c52935751d60c/third_party/blink/renderer/modules/animationworklet/worklet_animation.idl
[modify] https://crrev.com/f1310529d2e7817d7696bb8cac0c52935751d60c/third_party/blink/renderer/modules/animationworklet/worklet_animation_test.cc

Status: Fixed (was: Assigned)

Sign in to add a comment