"org.chromium.chrome.browser.media.MediaLauncherActivityTest#testHandleFileURIIntent" is flaky |
||||
Issue description"org.chromium.chrome.browser.media.MediaLauncherActivityTest#testHandleFileURIIntent" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyXgsSBUZsYWtlIlNvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIubWVkaWEuTWVkaWFMYXVuY2hlckFjdGl2aXR5VGVzdCN0ZXN0SGFuZGxlRmlsZVVSSUludGVudAw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Sep 11
Okay I'll disable for now. I think I know the cause and it's affecting some of the other tests in that file as well so I'll disable them all until it's fixed. example of other test fails: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel/78878 (#testHandleAudioIntent fails here) Looks like the root cause is that we recently updated the MediaLauncherActivity enabling logic to happen asynchronously, so if the test tries to run before the enabling task runs then it fails.
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/544e233efe256ec4c915fad1b5e288a2d2e96a08 commit 544e233efe256ec4c915fad1b5e288a2d2e96a08 Author: Tommy Steimel <steimel@chromium.org> Date: Tue Sep 11 22:58:13 2018 [Media Intent Handler] Disable flaky MediaLauncherActivityTest tests This CL disables the MediaLauncherActivityTest tests that are flaking due to a race condition. TBR: mlamouri@chromium.org Bug: 882938 Change-Id: I61ba23d0e4ed4a8890db8bcc0219ab4ea3804184 Reviewed-on: https://chromium-review.googlesource.com/1220701 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#590515} [modify] https://crrev.com/544e233efe256ec4c915fad1b5e288a2d2e96a08/chrome/android/javatests/src/org/chromium/chrome/browser/media/MediaLauncherActivityTest.java
,
Sep 12
Removing sheriff label as the test is disabled.
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1a96c67c8d5629c004accdc9576c8b842e0f02e commit a1a96c67c8d5629c004accdc9576c8b842e0f02e Author: Tommy Steimel <steimel@chromium.org> Date: Mon Sep 17 17:24:26 2018 [Media Intent Handler] Synchronize updating enabled for test This CL modifies MediaViewerUtil's method to force-enable the MediaLauncherActivity for testing to be synchronous. This prevents a race condition where a test tries to use the MediaLauncherActivity before the task to enable it has run. This CL also re-enables the tests that were disabled due to this issue. Bug: 882938 Change-Id: I18252427e7391104c580d0c5360141338cc1d56d Reviewed-on: https://chromium-review.googlesource.com/1220673 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#591721} [modify] https://crrev.com/a1a96c67c8d5629c004accdc9576c8b842e0f02e/chrome/android/java/src/org/chromium/chrome/browser/media/MediaViewerUtils.java [modify] https://crrev.com/a1a96c67c8d5629c004accdc9576c8b842e0f02e/chrome/android/javatests/src/org/chromium/chrome/browser/media/MediaLauncherActivityTest.java
,
Sep 17
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ojan@chromium.org
, Sep 11Status: Assigned (was: Untriaged)