DOMDistiller and PageRenovator tests are very flaky on Win10 Tests x64 (dbg) |
||||||||||
Issue description~1/5 runs of this bot has the same set of DOMDistiller tests fail, e.g. see https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/3055. DomDistillerJsTest.RunJsTests SecurityStateContentUtilsBrowserTest.VisibleSecurityStateInsecureFieldEdit DistillerPageWebContentsTest.HandlesRelativeVideos DistillerPageWebContentsTest.UsingCurrentWebContentsNoMainFrameObserver SecurityStateContentUtilsBrowserTest.VisibleSecurityStateNonsecureFormInputs SourceUrlRecorderWebContentsObserverBrowserTest.IgnoreUrlInSubframe PageRenovatorBrowserTest.WikipediaRenovationRuns DistillerPageWebContentsTest.PageDestroyedBeforeFinishDistillation DomDistillerDistillablePageUtilsTest.TestIsNotDistillablePage DistillerPageWebContentsTest.BasicDistillationWorks DistillerPageWebContentsTest.UsingCurrentWebContentsReadyForDistillation PageRenovatorBrowserTest.CorrectRenovationsRun DistillerPageWebContentsTest.TestPinch DistillerPageWebContentsTest.HandlesRelativeImages SourceUrlRecorderWebContentsObserverBrowserTest.Basic DistillerPageWebContentsTest.UsingCurrentWebContentsWrongUrl DomDistillerDistillablePageUtilsTest.TestIsDistillablePage DistillerPageWebContentsTest.VisibilityDetection DistillerPageWebContentsTest.MarkupInfo DistillerPageWebContentsTest.UsingCurrentWebContentsNotFinishedLoadingYet DistillerPageWebContentsTest.HandlesRelativeLinks
,
Sep 11
Looks like they're all timing out.
,
Sep 11
And they have been for at least the past 200 runs, so it's not a recent regression. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=components_browsertests&showAllRuns=true&tests=DomDistillerJsTest.RunJsTests
,
Sep 11
nyquist@, it's your team that owns DOM distiller, right? Please assign this appropriately if so. Should we even be running DOM distiller and PageRenovator tests on Windows since they are android only features (right?)? If there's some fix more complex than just disabling, please disable them in the meantime while the fix is happening so that the flakiness can be addressed ASAP.
,
Sep 12
There seems to be general problems with Win10 Tests x64, see bug 876224. Assigning for visibility.
,
Sep 18
Removing from sheriff queue.
,
Oct 8
Issue 864620 has been merged into this issue.
,
Oct 8
,
Oct 12
It seems this suite of tests has been problematic for a long time. I have a CL in the CQ to disable them on Win. Someone should triage all the old bugs that are related to these tests, and bring them all under this bug for tracking.
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c5f63ac3f3694369f816267127d31ead550580c commit 4c5f63ac3f3694369f816267127d31ead550580c Author: W. James MacLean <wjmaclean@chromium.org> Date: Fri Oct 12 16:19:22 2018 Disable flakey tests on Win. This suite of tests has been flakey for a *long* time on Windows, it's time to disable them until they are fixed. TBR=nyquist@chromium.org TBR=sky@chromium.org Bug: 882937 Change-Id: I383a959faeb2798a15ee0fe9c32a06c58af20573 Reviewed-on: https://chromium-review.googlesource.com/c/1278543 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#599243} [modify] https://crrev.com/4c5f63ac3f3694369f816267127d31ead550580c/components/dom_distiller/content/browser/distillable_page_utils_browsertest.cc [modify] https://crrev.com/4c5f63ac3f3694369f816267127d31ead550580c/components/dom_distiller/content/browser/distiller_page_web_contents_browsertest.cc [modify] https://crrev.com/4c5f63ac3f3694369f816267127d31ead550580c/components/offline_pages/content/renovations/test/page_renovator_browsertest.cc [modify] https://crrev.com/4c5f63ac3f3694369f816267127d31ead550580c/components/security_state/content/content_utils_browsertest.cc [modify] https://crrev.com/4c5f63ac3f3694369f816267127d31ead550580c/components/ukm/content/source_url_recorder_browsertest.cc
,
Oct 12
Issue 841536 has been merged into this issue.
,
Oct 12
,
Oct 12
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e1f59da2ca787e59e4c710391842341d5f65e3e commit 8e1f59da2ca787e59e4c710391842341d5f65e3e Author: W. James MacLean <wjmaclean@chromium.org> Date: Mon Oct 15 13:50:13 2018 Disable DomDistillerJsTest.RunJsTests. Disabling another flaky test from this suite. TBR=nyquist@chromium.org Bug: 882937 Change-Id: I53faca6b628a745ac543681f0adb34af00856144 Reviewed-on: https://chromium-review.googlesource.com/c/1280280 Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#599624} [modify] https://crrev.com/8e1f59da2ca787e59e4c710391842341d5f65e3e/components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc
,
Oct 17
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by ojan@chromium.org
, Sep 11