New issue
Advanced search Search tips

Issue 882926 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Position disconnect window in the center of the screen when in auto-hide mode

Project Member Reported by joedow@chromium.org, Sep 11

Issue description

This behavior is a result of discussions with the privacy team as we want to ensure a local user sees the disconnect window when it is set to auto-hide and using a centered position reduces the chances of the dialog being missed.

Ideally, we would like to merge this into our M70 release which has the auto-hide dialog behavior enabled.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ee01678ce0afa3b0028df16eb532185bfb830af

commit 8ee01678ce0afa3b0028df16eb532185bfb830af
Author: Joe Downing <joedow@chromium.org>
Date: Tue Sep 11 19:19:25 2018

Center the disconnect windows on screen when auto-hide is enabled

This change is a result of our discussions with the privacy folks.
The old behavior was to center the disconnect window along the
x-axis and dock it just above the taskbar.  The change is to now
position the dialog near the center of the y-axis as well to
maximize the chances of a local user seeing the disconnect window
before it auto-hides.

This change also fixes a bug where I was setting the position after
animating the window so it would appear to jump when being reshown.

BUG= 882926 

Change-Id: I3e923937f10f24c3e719f311380a98b77644e866
Reviewed-on: https://chromium-review.googlesource.com/1220029
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590434}
[modify] https://crrev.com/8ee01678ce0afa3b0028df16eb532185bfb830af/remoting/host/disconnect_window_win.cc

Labels: Merge-Request-70
Requesting an M70 merge for this is a change which was requested by the privacy team for an updated Chrome remote desktop feature.  Does not affect the browser.
Labels: -Merge-Request-70 Merge-Approved-70
Approved - branch:3538
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 13

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1db36b423458c917855140aa43c99462bc80c0bc

commit 1db36b423458c917855140aa43c99462bc80c0bc
Author: Joe Downing <joedow@chromium.org>
Date: Thu Sep 13 18:52:21 2018

Center the disconnect windows on screen when auto-hide is enabled

This change is a result of our discussions with the privacy folks.
The old behavior was to center the disconnect window along the
x-axis and dock it just above the taskbar.  The change is to now
position the dialog near the center of the y-axis as well to
maximize the chances of a local user seeing the disconnect window
before it auto-hides.

This change also fixes a bug where I was setting the position after
animating the window so it would appear to jump when being reshown.

BUG= 882926 

Change-Id: I3e923937f10f24c3e719f311380a98b77644e866
Reviewed-on: https://chromium-review.googlesource.com/1220029
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590434}(cherry picked from commit 8ee01678ce0afa3b0028df16eb532185bfb830af)
Reviewed-on: https://chromium-review.googlesource.com/1225271
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#377}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/1db36b423458c917855140aa43c99462bc80c0bc/remoting/host/disconnect_window_win.cc

Status: Fixed (was: Assigned)

Sign in to add a comment