Issue metadata
Sign in to add a comment
|
Select-to-Speak's Search+S is broken in Google Docs / Drive apps |
||||||||||||||||||||||||
Issue description# Select text using a mouse highlight and then pressing ctrl + s Expected: contents selected is spoken Actual: nothing is spoken, highlight appears around entire doc. This happens consistently. This was introduced in https://chromium-review.googlesource.com/1136842 on July 17 2018.
,
Sep 11
Google Chrome 70.0.3538.7 (Official Build) dev (64-bit) Firmware Version Google_Caroline.7820.384.0 Reproducing in corp docs (same as non-corp). Screen magnification support on vs off: same result, search + s doesn't read, search + mouse does read Braille mode enabled (checked): Text is read with search + s but the highlight is in the upper left corner. With search + mouse text is read and highlighted as expected. Braille mode not enabled (unchecked): Text is not read with search + s, with search + mouse text is read and highlighted as expected.
,
Sep 11
,
Sep 11
This regression appears to have been introduced in M69: 68.0.3440.118 (Official Build)(64-bit) Google_Eve.9584.151.0 Works as expected - text is read and highlighted regardless of braille mode 69.0.3497.87 (Official Build)(64-bit) Google_Eve.9584.160.0 Highlighting text and pressing search + s does nothing, plays earcon for invalid selection (with braille mode disabled)
,
Sep 11
Tracked internally at b/68974234
,
Sep 11
,
Sep 11
I've got a change for this that I'll try to merge into M70 after it lands in M71. It's too late for 69.
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/160e72c59bf76034c90285bb612dc2b3ea7d74cd commit 160e72c59bf76034c90285bb612dc2b3ea7d74cd Author: Katie D <katie@chromium.org> Date: Tue Sep 11 20:49:34 2018 Fix STS reading selected text in Docs with Search+S. This was introduced in https://chromium-review.googlesource.com/1136842. Bug: 882868 , 882923 Change-Id: I507ffe0d35dfe568276971ca1b6775fcc150896b Reviewed-on: https://chromium-review.googlesource.com/1219930 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#590460} [modify] https://crrev.com/160e72c59bf76034c90285bb612dc2b3ea7d74cd/chrome/browser/resources/chromeos/select_to_speak/input_handler.js [modify] https://crrev.com/160e72c59bf76034c90285bb612dc2b3ea7d74cd/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
,
Sep 11
,
Sep 12
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 12
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62c87f30ec20f661827ba28b4c0d7f147175de6f commit 62c87f30ec20f661827ba28b4c0d7f147175de6f Author: Katie D <katie@chromium.org> Date: Wed Sep 12 21:45:55 2018 Merge to M70: Fix STS reading selected text in Docs with Search+S. This was introduced in https://chromium-review.googlesource.com/1136842. TBR=dtseng@chromium.org Bug: 882868 , 882923 Change-Id: I507ffe0d35dfe568276971ca1b6775fcc150896b Reviewed-on: https://chromium-review.googlesource.com/1219930 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#590460}(cherry picked from commit 160e72c59bf76034c90285bb612dc2b3ea7d74cd) Reviewed-on: https://chromium-review.googlesource.com/1222698 Reviewed-by: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#345} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/62c87f30ec20f661827ba28b4c0d7f147175de6f/chrome/browser/resources/chromeos/select_to_speak/input_handler.js [modify] https://crrev.com/62c87f30ec20f661827ba28b4c0d7f147175de6f/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
,
Sep 12
,
Sep 20
Hi Katie, This change isn't in 70.0.3538.16 (Official Build) dev (64-bit), the bug still reproduces, with braille support off, highlighting text then pressing search + s does not read the text. I noted in the CL above that it was expected to land in MAJOR=70 MINOR=0 BUILD=3538 PATCH=16 Please let me know if I need to wait for a later version?
,
Sep 25
Could you try again? Looks like 3538.16 only branched on the 12th, so there's a good chance it didn't make it. See timestamp here: https://chromium.googlesource.com/chromium/src/+/70.0.3538.16 I'm not sure when it landed, but certainly by 3538.32: https://chromium.googlesource.com/chromium/src/+log/70.0.3538.32/chrome/browser/resources/chromeos/select_to_speak
,
Oct 5
Google Chrome 71.0.3567.0 (Official Build) dev (64-bit) Firmware Version Google_Caroline.7820.384.0 Verified as speaking with braille mode off. Text is not highlighted, highlight is still around the entire doc. This is working as expected after confirming behavior with katie@. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by katie@chromium.org
, Sep 11