Add a finch based size limit on max page hints that can be loaded to the memory |
||||||
Issue descriptionFor resource loading hints intervention, we need to add a finch based paramater that controls how many page hints can be loaded to the memory. Initially, we have decided to set the limit to 500, and measure if there are any memory regressions. Having this parameter enables us to set different limits for low memory vs high memory devices. It also provides an additional safeguard against memory bloats in case the component updater contains too many hints.
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e46005cead4da2c83697332111926369d64906b2 commit e46005cead4da2c83697332111926369d64906b2 Author: Tarun Bansal <tbansal@chromium.org> Date: Wed Sep 12 00:32:39 2018 Limit the number of page hints that can be loaded to the memory The threshold is controlled using field trial. Also, add few more histograms to track any regressions. Change-Id: I7901f70196dd23de5eec6fc9574602c71fbe0235 Bug: 882913 Reviewed-on: https://chromium-review.googlesource.com/1214748 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#590550} [modify] https://crrev.com/e46005cead4da2c83697332111926369d64906b2/components/previews/content/previews_hints.cc [modify] https://crrev.com/e46005cead4da2c83697332111926369d64906b2/components/previews/content/previews_optimization_guide_unittest.cc [modify] https://crrev.com/e46005cead4da2c83697332111926369d64906b2/components/previews/core/previews_experiments.cc [modify] https://crrev.com/e46005cead4da2c83697332111926369d64906b2/components/previews/core/previews_experiments.h [modify] https://crrev.com/e46005cead4da2c83697332111926369d64906b2/tools/metrics/histograms/histograms.xml
,
Sep 13
,
Sep 13
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 17
Approved for merge into 70, branch 3538.
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac0f6fe3b596dbf11d83564dda0775b6fc10ba93 commit ac0f6fe3b596dbf11d83564dda0775b6fc10ba93 Author: Tarun Bansal <tbansal@chromium.org> Date: Mon Sep 17 20:35:27 2018 Limit the number of page hints that can be loaded to the memory The threshold is controlled using field trial. Also, add few more histograms to track any regressions. Change-Id: I7901f70196dd23de5eec6fc9574602c71fbe0235 Bug: 882913 Reviewed-on: https://chromium-review.googlesource.com/1214748 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Doug Arnett <dougarnett@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#590550}(cherry picked from commit e46005cead4da2c83697332111926369d64906b2) Reviewed-on: https://chromium-review.googlesource.com/1228947 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#460} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/ac0f6fe3b596dbf11d83564dda0775b6fc10ba93/components/previews/content/previews_hints.cc [modify] https://crrev.com/ac0f6fe3b596dbf11d83564dda0775b6fc10ba93/components/previews/content/previews_optimization_guide_unittest.cc [modify] https://crrev.com/ac0f6fe3b596dbf11d83564dda0775b6fc10ba93/components/previews/core/previews_experiments.cc [modify] https://crrev.com/ac0f6fe3b596dbf11d83564dda0775b6fc10ba93/components/previews/core/previews_experiments.h [modify] https://crrev.com/ac0f6fe3b596dbf11d83564dda0775b6fc10ba93/tools/metrics/histograms/histograms.xml
,
Sep 17
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tbansal@chromium.org
, Sep 11