New issue
Advanced search Search tips

Issue 882908 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task

Blocking:
issue 873684



Sign in to add a comment

Add touch pointerrawmoves

Project Member Reported by nzolghadr@chromium.org, Sep 11

Issue description

We need to send pointerrawmove events for touch event path as well.
 
Labels: -Type-Bug Type-Task
Blocking: 873684
Cc: tbuck...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc4fa35bf0852532e34873aabd94936e4a93799b

commit cc4fa35bf0852532e34873aabd94936e4a93799b
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Fri Sep 14 16:32:44 2018

Send pointerrawmove for touch event path

Enable pointerrawmove events for touch event
path as well.

Bug:  882908 
Change-Id: I263b6dfdd4cccf0fb1fcfbe0bb5581411b5f5e79
Reviewed-on: https://chromium-review.googlesource.com/1219967
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591368}
[modify] https://crrev.com/cc4fa35bf0852532e34873aabd94936e4a93799b/content/renderer/input/main_thread_event_queue.cc
[modify] https://crrev.com/cc4fa35bf0852532e34873aabd94936e4a93799b/content/renderer/input/main_thread_event_queue_unittest.cc

Labels: -Pri-3 Merge-Request-70 Pri-2
Can you please mark which OS's this is impacting?
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 15

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
abdulsyed@ I added the all the affected platforms. This whole change is behind the flag and doesn't have any effect on the normal Chrome running. But it is needed for some teams testing with that feature on.
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 18

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05a520420b86ce02f12addfa8f35c50832b903c5

commit 05a520420b86ce02f12addfa8f35c50832b903c5
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Tue Sep 18 14:20:49 2018

Send pointerrawmove for touch event path

Enable pointerrawmove events for touch event
path as well.

Bug:  882908 
Change-Id: I263b6dfdd4cccf0fb1fcfbe0bb5581411b5f5e79
Reviewed-on: https://chromium-review.googlesource.com/1219967
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591368}(cherry picked from commit cc4fa35bf0852532e34873aabd94936e4a93799b)
Reviewed-on: https://chromium-review.googlesource.com/1230693
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#491}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/05a520420b86ce02f12addfa8f35c50832b903c5/content/renderer/input/main_thread_event_queue.cc
[modify] https://crrev.com/05a520420b86ce02f12addfa8f35c50832b903c5/content/renderer/input/main_thread_event_queue_unittest.cc

Status: Fixed (was: Assigned)
Tom I just merged this into 70.

Sign in to add a comment