loading.desktop/AllRecipes_cold in performance_test_suite failing on chromium.perf/Win 7 Perf |
|||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of charliea@chromium.org loading.desktop/AllRecipes_cold in performance_test_suite failing on chromium.perf/Win 7 Perf Builders failed on: - Win 7 Perf: https://ci.chromium.org/buildbot/chromium.perf/Win%207%20Perf Failure looks like: (ERROR) 2018-08-23 15:19:22,967 story_runner.ProcessError:100 Handleable error Traceback (most recent call last): File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\story_runner.py", line 126, in _RunStoryAndProcessErrorIfNeeded state.RunStory(results) File "c:\b\s\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function return func(*args, **kwargs) File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\page\shared_page_state.py", line 300, in RunStory self._current_page.Run(self) File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\page\__init__.py", line 99, in Run self.RunPageInteractions(action_runner) File "c:\b\s\w\ir\tools\perf\page_sets\page_cycler_story.py", line 41, in RunPageInteractions _WEB_CONTENTS_TIMEOUT) File "c:\b\s\w\ir\third_party\catapult\common\py_utils\py_utils\__init__.py", line 148, in WaitFor (timeout, GetConditionString())) Looks like it's timing out waiting for quiescence. Approximate good revision is r584948, first failure is r585471. Going to kick off a bisect to see if we can find the culprit.
,
Sep 11
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/17cbfd9b640000 [CrOS Multidevice] Authenticate user before enabling some features. by hansberry@chromium.org https://chromium.googlesource.com/chromium/src/+/56d3d720c25268184350c8830c6c9776abcd652e 0.8 → 0.1 (-0.7) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/loading-benchmarks
,
Sep 12
Hi Ryan, It looks like the above CL broke some Chrome loading benchmarks. Is it safe to revert while you investigate the cause of the failure?
,
Sep 12
+khorimoto@,jlklein@,jhawkins@ Hi Charlie -- please don't revert this CL. This commit should only affect Chrome OS, not Windows. All previous changes to these files have not produced this type of issue, so I'm certain this is some sort of flake in the tool, or it's pinpointing the wrong culprit CL. If you have reason to believe I'm incorrect here, I can try to help you investigate the issue, but I'm unfamiliar with this tool / performance testing infra. Thanks!
,
Sep 12
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/132ab8e3640000
,
Sep 12
Hi Ryan, Rerunning the job now to double check its findings.
,
Sep 12
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/132ab8e3640000
,
Sep 12
I couldn't tell from your link what actual test is broken. Can you help us understand? I've audited the change, and the files in the CL are all HTML/CSS/JS which are included in [1]. However, all of those files are wrapped in a "<if expr="chromeos">" tag, so I don't see how this could regress Windows performance. [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settings_resources.grd
,
Sep 12
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/157bc1e3640000
,
Sep 12
Hi khorimoto@, Based on hansberry@'s comment, I wouldn't worry about this too much until we can actually reproduce the bisect that initially led us to believe it was their CL. It sounds like this is more likely than not a flake.
,
Sep 12
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/157bc1e3640000 |
|||
►
Sign in to add a comment |
|||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Sep 11