New issue
Advanced search Search tips

Issue 882895 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 816545



Sign in to add a comment

LoadingPredictor cleanup

Project Member Reported by alexilin@chromium.org, Sep 11

Issue description

There is couple of things that require a clean-up in the LoadingPredictor
* The code handling experimental config
* UMA reporting
* Legacy file and class names like ResourcePrefetchPredictor and GlowplugKeyValueTable
 
Blocking: 816545
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e47eade042c947d577a446629f6bc09806ec4f1c

commit e47eade042c947d577a446629f6bc09806ec4f1c
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Wed Sep 12 14:38:54 2018

predictors: LoadingPredictor config cleanup

This CL removes the code used to configure SpeculativePreconnect experiment and
simplifies LoadingPredictor configuration states.

The kSpeculativePreconnectFeature is kept untouched since it's used to disable
the feature in some browser tests and it may be useful as a kill switch.

Bug: 882895
Change-Id: I93e20622fa823599fa1ffd105806d7f8f6e2956a
Reviewed-on: https://chromium-review.googlesource.com/1219866
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590674}
[modify] https://crrev.com/e47eade042c947d577a446629f6bc09806ec4f1c/chrome/browser/about_flags.cc
[modify] https://crrev.com/e47eade042c947d577a446629f6bc09806ec4f1c/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/e47eade042c947d577a446629f6bc09806ec4f1c/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/e47eade042c947d577a446629f6bc09806ec4f1c/chrome/browser/page_load_metrics/observers/loading_predictor_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e47eade042c947d577a446629f6bc09806ec4f1c/chrome/browser/predictors/loading_data_collector.cc
[modify] https://crrev.com/e47eade042c947d577a446629f6bc09806ec4f1c/chrome/browser/predictors/loading_predictor.cc
[modify] https://crrev.com/e47eade042c947d577a446629f6bc09806ec4f1c/chrome/browser/predictors/loading_predictor_config.cc
[modify] https://crrev.com/e47eade042c947d577a446629f6bc09806ec4f1c/chrome/browser/predictors/loading_predictor_config.h
[modify] https://crrev.com/e47eade042c947d577a446629f6bc09806ec4f1c/chrome/browser/predictors/loading_predictor_config_unittest.cc
[modify] https://crrev.com/e47eade042c947d577a446629f6bc09806ec4f1c/chrome/browser/predictors/loading_predictor_factory.cc
[modify] https://crrev.com/e47eade042c947d577a446629f6bc09806ec4f1c/chrome/browser/predictors/loading_predictor_unittest.cc
[modify] https://crrev.com/e47eade042c947d577a446629f6bc09806ec4f1c/chrome/browser/predictors/loading_test_util.cc
[modify] https://crrev.com/e47eade042c947d577a446629f6bc09806ec4f1c/chrome/browser/predictors/preconnect_manager.cc
[modify] https://crrev.com/e47eade042c947d577a446629f6bc09806ec4f1c/chrome/browser/predictors/predictor_database.cc
[modify] https://crrev.com/e47eade042c947d577a446629f6bc09806ec4f1c/chrome/browser/predictors/resource_prefetch_predictor.cc

Sign in to add a comment