Missing app name in "Open with" dialog |
||
Issue descriptionChrome version: (copy from chrome://version) OS: Chrome Repro steps: 1. Enable Crostini and install VS Code 2. In Files.app, select a .txt file in Downloads, click "Open" menu, and change default to VS Code 3. Right-click the .txt file and select "VS Code" from the top of the menu Expected: dialog explains that it is unable to open with VS Code Actual: VS Code is missing from title (see attached)
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/035273cd704fec1be98295f237fe9a8f97628690 commit 035273cd704fec1be98295f237fe9a8f97628690 Author: Timothy Loh <timloh@chromium.org> Date: Fri Sep 14 01:27:40 2018 Fix missing linux app name in "Open with" error dialog When attempting to open a file in the file manager via the context menu with a Linux app that has been set to the default, the error dialog shown if the file is not in Linux Files was not getting the app name. This CL fixes the dialog to correctly show the app name. As the object we were originally passing in is a html element, we can't simply add the 'title' attribute to it, as this will be reflected as a mouseover tooltip. Bug: 882894 Change-Id: Iccfdeaba720869046e2ea60367d687a5556abdf4 Reviewed-on: https://chromium-review.googlesource.com/1221068 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#591253} [modify] https://crrev.com/035273cd704fec1be98295f237fe9a8f97628690/ui/file_manager/file_manager/foreground/js/task_controller.js [modify] https://crrev.com/035273cd704fec1be98295f237fe9a8f97628690/ui/file_manager/file_manager/test/crostini.js
,
Sep 17
|
||
►
Sign in to add a comment |
||
Comment 1 by slangley@chromium.org
, Sep 11