New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 882891 link

Starred by 1 user
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Sep 21
Cc:
cindyb@chromium.org
geo...@google.com
tbuck...@chromium.org
█ ggranito@chromium.org
█ dovizu@google.com
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Scarlet missing option to not show stylus tools on eject

Project Member Reported by tbuck...@chromium.org, Sep 11 
Chrome Version: 70.0.3538.7 dev
OS Version: Chrome

What steps will reproduce the problem?
1. On Scarlet, open Settings > Device > Stylus
2. Look for setting "Open stylus tools when the stylus is removed"

What is the expected result? Setting is there
What happens instead of that? Setting is missing
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/34843ad86cbdce7c0eeb78ab81561b19be5065da

commit 34843ad86cbdce7c0eeb78ab81561b19be5065da
Author: Sammie Quon <sammiequon@google.com>
Date: Sat Sep 15 05:00:21 2018

scarlet: Add use internal_stylus.

Scarlet has an internal stylus so it should have this flag.

BUG= chromium:882891 
TEST=Flash a new image and palette tools tray shows up

Change-Id: I4c6cf704bdfbbba0e1948044704e678581248cab
Reviewed-on: https://chromium-review.googlesource.com/1226277
Commit-Ready: Sammie Quon <sammiequon@chromium.org>
Tested-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/34843ad86cbdce7c0eeb78ab81561b19be5065da/overlay-scarlet/profiles/base/make.defaults

Comment 2 by sammiequon@chromium.org, Sep 17

Labels: Merge-Request-70 Merge-Request-69
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 17

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by cindyb@chromium.org, Sep 17

Labels: -Merge-Request-69 M-69 Merge-Approved-69
Merge approved, M69.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 17

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/c9eb514de3d51e49296890108b1e5f51449a3b6e

commit c9eb514de3d51e49296890108b1e5f51449a3b6e
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Sep 17 21:46:09 2018

scarlet: Add use internal_stylus.

Scarlet has an internal stylus so it should have this flag.

BUG= chromium:882891 
TEST=Flash a new image and palette tools tray shows up

Change-Id: I4c6cf704bdfbbba0e1948044704e678581248cab
Reviewed-on: https://chromium-review.googlesource.com/1226281
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Tested-by: Sammie Quon <sammiequon@chromium.org>
Trybot-Ready: Sammie Quon <sammiequon@chromium.org>

[modify] https://crrev.com/c9eb514de3d51e49296890108b1e5f51449a3b6e/overlay-scarlet/profiles/base/make.defaults
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 21

Cc: cindyb@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by geo...@google.com, Sep 21

Labels: -Merge-Review-70 Merge-Approved-70
Approved for 70
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 21

Labels: merge-merged-release-R70-11021.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/0237fedbefda450e0b7e855102267578710d8b32

commit 0237fedbefda450e0b7e855102267578710d8b32
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Sep 21 17:27:19 2018

scarlet: Add use internal_stylus.

Scarlet has an internal stylus so it should have this flag.

BUG= chromium:882891 
TEST=Flash a new image and palette tools tray shows up

Change-Id: I4c6cf704bdfbbba0e1948044704e678581248cab
Reviewed-on: https://chromium-review.googlesource.com/1226280
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Tested-by: Sammie Quon <sammiequon@chromium.org>
Trybot-Ready: Sammie Quon <sammiequon@chromium.org>

[modify] https://crrev.com/0237fedbefda450e0b7e855102267578710d8b32/overlay-scarlet/profiles/base/make.defaults

Comment 9 by sammiequon@chromium.org, Sep 21

Status: Fixed (was: Assigned)
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 25

Cc: geo...@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by sammiequon@chromium.org, Sep 25

Labels: -Merge-Approved-69 -Merge-Approved-70
►

Sign in to add a comment