New issue
Advanced search Search tips

Issue 882890 link

Starred by 1 user
Status: Verified
Owner:
nicolaso@chromium.org
Closed: Sep 17
Cc:
pastarmovj@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 914423



Sign in to add a comment

Don't switch browsers in Incognito mode

Project Member Reported by nicolaso@chromium.org, Sep 11 
We should include logic so that BrowserSwitcher doesn't do anything in Incognito mode.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd216440a2c813f231722541c8979d31fba0a3ca

commit dd216440a2c813f231722541c8979d31fba0a3ca
Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Date: Mon Sep 17 16:41:51 2018

[BrowserSwitcher] Don't switch browsers in Incognito

This keeps BrowserSwitcher behavior in line with the LBS extension.

Bug:  882890 
Change-Id: I35f9b5e9a2bd2296a23fa70454f4972739e2b34d
Reviewed-on: https://chromium-review.googlesource.com/1227140
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591705}
[modify] https://crrev.com/dd216440a2c813f231722541c8979d31fba0a3ca/chrome/browser/browser_switcher/browser_switcher_navigation_throttle.cc

Comment 2 by nicolaso@chromium.org, Sep 17

Status: Verified (was: Assigned)
►

Sign in to add a comment