New issue
Advanced search Search tips

Issue 882881 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

blink_perf.bindings structure-clon-json-[de]serialize.html failing on Nexus5 Perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Sep 11

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of charliea@chromium.org

blink_perf.bindings/structured-clone-json-deserialize.html and 7 other(s) in performance_test_suite failing on chromium.perf/Android Nexus5 Perf

Builders failed on: 
- Android Nexus5 Perf: 
  https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus5%20Perf


 
Looks like the suspected revision range is r588726 to r588793.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b98869f2248f2ba365edd035fb91516247f2e962

commit b98869f2248f2ba365edd035fb91516247f2e962
Author: Charlie Andrews <charliea@chromium.org>
Date: Tue Sep 11 15:22:59 2018

Disable failing Nexus5 blink_perf.bindings stories

TBR=sullivan@chromium.org
NOTRY=true
CC=yukishiino@chromium.org, jbroman@chromium.org, haraken@chromium.org

Bug: 882881,  882882 ,  882883 
Change-Id: Id509634ea963f688bc5cc0b761b1430398688ea2
Reviewed-on: https://chromium-review.googlesource.com/1219783
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590318}
[modify] https://crrev.com/b98869f2248f2ba365edd035fb91516247f2e962/tools/perf/expectations.config

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/1295c2cb640000
Components: Blink>Bindings
Status: Untriaged (was: Available)
There are two other bugs for similar tests on the same day, so duping them on this one.
 Issue 882882  has been merged into this issue.
 Issue 882883  has been merged into this issue.
Owner: adithyas@chromium.org
Status: Assigned (was: Untriaged)
Adithya, do you have bandwidth to look into what happened here?
Cc: -yukishiino@chromium.org adithyas@chromium.org
Owner: yuzus@chromium.org
Looks like https://crrev.com/3e67ba415000dddd1dabbdee7aa69be9d7138980 is the culprit, reverting it locally fixed the test.

yuzus@: The performance test here uses a lot of memory and triggers the OOM intervention, and then the test hangs. We should probably disable it for the telemetry performance tests. 
Cc: kdillon@chromium.org
Just a note: now that worker-structured-clone-json-serialize.html has been split into worker-structured-clone-json-from-worker.html and worker-structured-clone-json-to-worker.html, this bug is responsible for those tests failing, too.

Adding kdillon@, the author of the CL that split that test (https://chromium-review.googlesource.com/c/chromium/src/+/1265085)
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6f534ce4c6dcaad2e6eb51116e1552006eca987

commit e6f534ce4c6dcaad2e6eb51116e1552006eca987
Author: Charlie Andrews <charliea@chromium.org>
Date: Wed Oct 10 18:08:01 2018

Disable new and failing blink_perf.bindings tests

These tests were split off from worker-structured-clone-json-from-worker
which was already failing on N5 and N5X.

NOTRY=true
TBR=nednguyen@chromium.org
CC=​haraken@chromium.org, kdillon@chromium.org,panicker@chromium.org,jbroman@chromium.org

Bug: 882881
Change-Id: I3bbd8c98bafa631b98f503373c0f6b7032ec6a0b
Reviewed-on: https://chromium-review.googlesource.com/c/1273967
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598402}
[modify] https://crrev.com/e6f534ce4c6dcaad2e6eb51116e1552006eca987/tools/perf/expectations.config

Sign in to add a comment