Issue metadata
Sign in to add a comment
|
Regression: STS not reading contents of G Suite Editors |
||||||||||||||||||||||||
Issue descriptionGoogle Chrome 70.0.3538.7 (Official Build) dev (64-bit) Firmware Version Google_Caroline.7820.384.0 Steps to reproduce: # Enable Select To Speak using Settings > Manage Accessibility Settings # Open a Google doc or sheet # Select text by holding down search and dragging the focus ring around text Expected: Contents selected is spoken Actual: entire document gets spoken, title of the doc is read part of the time, part of the time the text itself is read. This is an intermittent issue. # Select text using a mouse highlight and then pressing ctrl + s Expected: contents selected is spoken Actual: nothing is spoken, highlight appears around entire doc. This happens consistently. This does not reproduce on Gmail tracked internally in b/68974234
,
Sep 11
,
Sep 11
67.0.3396.00 (Official Build)(64-bit) Google_Eve.9584.107.0 Works as expected - text is read and highlighted in both scenarios
,
Sep 11
68.0.3440.118 (Official Build)(64-bit) Google_Eve.9584.151.0 Works as expected - text is read and highlighted in both scenarios
,
Sep 11
69.0.3497.87 (Official Build)(64-bit) Google_Eve.9584.160.0 Works partially: Highlighting text and pressing search + s does nothing, plays earcon for invalid selection Hold down search + drag around the text works as expected, text is read and highlighted
,
Sep 11
71.0.3544.0 (Official Build) canary (64-bit) Google_Eve.9584.160.0 Works partially: Highlighting text and pressing search + s does nothing, plays earcon for invalid selection Hold down search + drag around the text works as expected, text is read and highlighted
,
Sep 11
,
Sep 11
Hi Laura, thanks for catching this! I've got a few clarifying questions: * Do you have Braille mode on in Docs/Drive? * Are you using the same version of Docs to test each version of Chrome? * What do you mean by "works intermittently"? What's the #fail / #tested that you've observed?
,
Sep 11
,
Sep 11
With search+mouse or STS button + mouse, I can only reproduce this when I turn on Select-to-Speak *AFTER* loading the Google Docs page. If I refresh the Google Docs after enabling Select-to-Speak, I find that it speaks as expected. Laura, if you always refresh Google Docs after enabling Select-to-Speak, can you still reproduce this issue with search+mouse? Assigning to you for repro. Note: I've split the search+S part into a separate bug.
,
Sep 11
I answered the question about braille mode on/off over in 882923. With braille mode enabled, the text is read but the focus ring is in the upper left corner. As for search + mouse, I can repro 100% if I turn STS on after loading the Doc. Great catch, that resolves the "intermittent" nature of this bug. I had only been able to repro 1/5 times - that's why. I'm going to resolve this bug and open a new one just for the STS after doc has loaded bug.
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/160e72c59bf76034c90285bb612dc2b3ea7d74cd commit 160e72c59bf76034c90285bb612dc2b3ea7d74cd Author: Katie D <katie@chromium.org> Date: Tue Sep 11 20:49:34 2018 Fix STS reading selected text in Docs with Search+S. This was introduced in https://chromium-review.googlesource.com/1136842. Bug: 882868 , 882923 Change-Id: I507ffe0d35dfe568276971ca1b6775fcc150896b Reviewed-on: https://chromium-review.googlesource.com/1219930 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#590460} [modify] https://crrev.com/160e72c59bf76034c90285bb612dc2b3ea7d74cd/chrome/browser/resources/chromeos/select_to_speak/input_handler.js [modify] https://crrev.com/160e72c59bf76034c90285bb612dc2b3ea7d74cd/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62c87f30ec20f661827ba28b4c0d7f147175de6f commit 62c87f30ec20f661827ba28b4c0d7f147175de6f Author: Katie D <katie@chromium.org> Date: Wed Sep 12 21:45:55 2018 Merge to M70: Fix STS reading selected text in Docs with Search+S. This was introduced in https://chromium-review.googlesource.com/1136842. TBR=dtseng@chromium.org Bug: 882868 , 882923 Change-Id: I507ffe0d35dfe568276971ca1b6775fcc150896b Reviewed-on: https://chromium-review.googlesource.com/1219930 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#590460}(cherry picked from commit 160e72c59bf76034c90285bb612dc2b3ea7d74cd) Reviewed-on: https://chromium-review.googlesource.com/1222698 Reviewed-by: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#345} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/62c87f30ec20f661827ba28b4c0d7f147175de6f/chrome/browser/resources/chromeos/select_to_speak/input_handler.js [modify] https://crrev.com/62c87f30ec20f661827ba28b4c0d7f147175de6f/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by leberly@chromium.org
, Sep 11