New issue
Advanced search Search tips

Issue 882864 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 882865

Blocking:
issue 883318
issue 883330



Sign in to add a comment

Convert arc_session_manager_browsertest.cc to use IdentityManager

Project Member Reported by blundell@chromium.org, Sep 11

Issue description

It uses a fake PO2TS injected into the Profile. We don't yet have nice //chrome-level infrastructure to hide the usage of the fake PO2TS here (see blocking bug).
 
Blockedon: 882865
Blocking: 883318
Blocking: 883330
Labels: Proj-Servicification-VendorBug
Summary: Convert arc_session_manager_browsertest.cc to use IdentityManager (was: Determine how to convert arc_session_manager_browsertest.cc's usage of ProfileOAuth2TokenService to IdentityManager)
We have the necessary infrastructure now via IdentityTestEnvironmentProfileAdaptor.
Status: Started (was: Available)
OK working on this then...
Owner: svillar@chromium.org
Owner: svil...@igalia.com
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09c92d7a6b08216c43dc991001d8837a4e38b720

commit 09c92d7a6b08216c43dc991001d8837a4e38b720
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Tue Nov 20 09:19:00 2018

Convert arc_session_manager_browsertest.cc to use IdentityManager

It was using both SigninManager and ProfileOAuth2TokenService fake
objects injected in the profile to signin the user with a refresh
token. The IdentityTestEnvironmentProfileAdaptor could be used to
create the testing profile followed by
IdentityTestEnvironment::MakePrimaryAccountAvailable() to perform the
signin.

Bug:  882864 
Change-Id: I6d546a722a0eda4f3d14d6234d819a3964c7d92e
Reviewed-on: https://chromium-review.googlesource.com/c/1338107
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#609637}
[modify] https://crrev.com/09c92d7a6b08216c43dc991001d8837a4e38b720/chrome/browser/chromeos/arc/arc_session_manager_browsertest.cc

Status: Fixed (was: Started)
Closing

Sign in to add a comment