New issue
Advanced search Search tips

Issue 882862 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 8
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 890796

Blocking:
issue 883318



Sign in to add a comment

Convert browsing_data_counter_utils.cc to use IdentityManager rather than ProfileOAuth2TokenService

Project Member Reported by blundell@chromium.org, Sep 11

Issue description

Currently blocked on missing API (see blocking bug).
 
Labels: Proj-Servicification-VendorBug
Blocking: 883318
Owner: ma...@igalia.com
Status: Started (was: Available)
Taking this one. CL here:
https://chromium-review.googlesource.com/c/chromium/src/+/1255624
Blockedon: 890796
This now depends on  crbug.com/890796  to be completely migrated (see TODO note in the CL). Setting dependency.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b528f414ea5f923e859e21fca15f18eab2ec98a

commit 7b528f414ea5f923e859e21fca15f18eab2ec98a
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Mon Oct 08 10:21:19 2018

Convert browsing_data_counter_utils.cc to use IdentityManager

Migrate from using ProfileOAuth2TokenService and SigninManager to using
the IdentityManager instead, and remove the related includes.

Bug:  882862 
Change-Id: I5fb46927ffba508e6987f615ed22bc1a90155607
Reviewed-on: https://chromium-review.googlesource.com/c/1255624
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#597519}
[modify] https://crrev.com/7b528f414ea5f923e859e21fca15f18eab2ec98a/chrome/browser/browsing_data/counters/browsing_data_counter_utils.cc

Status: Fixed (was: Started)

Sign in to add a comment