New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 882858 link

Starred by 1 user
Status: Closed
Owner:
█ jamwalla@chromium.org
Last visit > 30 days ago
Closed: Oct 23
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Regression: Default focus is seen on 'Reset' button of zoom bubble for second instance.

Reported by db...@etouch.net, Sep 11 
Chrome Version : 71.0.3549.0 (Official Build) 09b135be6dd0aee298f10cd511efd6574d2edd7f-refs/branch-heads/3549@{#1} 32/64 bit
OS : Windows (7, 8, 8.1),Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTs).

What steps will reproduce the problem?
(1) Launch chrome, open NTP and press Ctrl-- to zoom out page.
(2) Observe zoom bubble, then click again click on zoom icon and observe zoom bubble.

Actual: Default focus is seen on Reset button for second instance.

Expected: Default focus on Reset button should seen always.

This is a regression issue, broken in 'M71', below is bisect info:

Good Build:71.0.3548.0
Bad Build:71.0.3549.0

You are probably looking for a change made after 589672(known good), but no later than 589673(first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/03fd02e99302521272cdac123a2adb08f0acf447..c4cb73ecadad6fcb2536101a227c55e114017e5e

Suspect: https://chromium.googlesource.com/chromium/src/+/c4cb73ecadad6fcb2536101a227c55e114017e5e

@jamwalla: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.


Thank you.
Actual_Zoom.mov
4.4 MB View Download
Expected_Zoom.mov
1.6 MB View Download

Comment 1 by jamwalla@chromium.org, Sep 11 

This is caused by my change. Since the bubble itself can't be focused, the widget focuses the return button in GetInitiallyFocusedView. This was changed so that the bubble is keyboard accessible - screen reader users can press Alt+Shift+A to interact with the bubble. (See  issue 849486 .)

Changing the zoom level with the keyboard causes the bubble to be shown but does not focus the bubble, since the user isn't trying to interact with the bubble yet. Clicking the zoom icon in the omnibox causes the bubble to be shown *and* focused, since the user explicitly wants to interact with the bubble.

Let me know if this is an acceptable change in behavior, or if there's another way we can make the bubble accessible by keyboard. Thanks!

Comment 2 by jamwalla@chromium.org, Sep 17

Cc: est...@chromium.org
+estade, this was caused by my change, can you weigh in on if this is a proper regression?

Comment 3 by jamwalla@chromium.org, Oct 23

Status: Closed (was: Assigned)
Closing as this was reverted along with  issue 894006 .
►

Sign in to add a comment