New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 882846 link

Starred by 1 user
Status: Fixed
Owner:
█ valeriyas@google.com
Last visit > 30 days ago
Closed: Sep 25
Cc:
droger@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 771911



Sign in to add a comment

Use TickClock in gaia_cookie_manager_service_unittests

Project Member Reported by valeriyas@google.com, Sep 11 
Change base::RunLoop usage in gaia_cookie_manager_service_unittests to TickClock to speed up testing.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94412cb311654e5e50b429d6d44412e60d66807e

commit 94412cb311654e5e50b429d6d44412e60d66807e
Author: Valeriya Sinevich <valeriyas@google.com>
Date: Tue Sep 25 09:22:33 2018

[Signin] Mock TaskRunner in tests to avoid waiting.

Remove waiting until fetcher retries after failure and use mock task runner instead to skip waiting time.

Bug:  882846 
Change-Id: Id202e2845bdc8bc0528dadb70731829d8087bac3
Reviewed-on: https://chromium-review.googlesource.com/1238498
Commit-Queue: Valeriya Sinevich <valeriyas@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593872}
[modify] https://crrev.com/94412cb311654e5e50b429d6d44412e60d66807e/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc

Comment 2 by droger@chromium.org, Sep 25

Status: Fixed (was: Assigned)
►

Sign in to add a comment