DCHECK failure when playing HTML5 video from a data: URL
Reported by
pkalinow...@opera.com,
Sep 11
|
||
Issue descriptionSteps to reproduce the problem: 1. Go to https://edition.cnn.com/2018/08/02/politics/ocasio-cortez-michigan-abdul-el-sayed-whitmer/index.html 2. Scroll through the page, and click Read More. 3. Find the related video and try to play it. What is the expected behavior? It just plays. What went wrong? DCHECK is triggered in http_auth_cache: [FATAL:http_auth_cache.cc(47)] Check failed: origin.is_valid. The reason for this is because one of the video elements, fave-ad-player-2, has a data URL as a source. This is not a "standard" URL, which means that it has no origin to provide to auth cache for the purpose of looking up auth information. Did this work before? N/A Chrome version: 69.0.3497.42 Channel: n/a OS Version: Flash Version:
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/621b28fb383f2f2cdc45618100ce82e10204f513 commit 621b28fb383f2f2cdc45618100ce82e10204f513 Author: Piotr Kalinowski <pkalinowski@opera.com> Date: Tue Sep 18 12:03:45 2018 Do not try to look up non-standard URLs in auth cache Auth cache uses URL's origin as a key, and non-standard URLs don't have it, so it only results in an attempt to use an invalid key, trigerring a DCHECK on the way, too. This can happen if page uses a data URL as a source for an HTML5 video. Bug: 882842 Change-Id: I0a1861d27152d4d84f3a7692fd94af6222ca027c Reviewed-on: https://chromium-review.googlesource.com/1219607 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Piotr Kalinowski <pkalinowski@opera.com> Cr-Commit-Position: refs/heads/master@{#592005} [modify] https://crrev.com/621b28fb383f2f2cdc45618100ce82e10204f513/content/browser/media/android/media_resource_getter_impl.cc
,
Oct 4
Is this fixed now?
,
Oct 5
I believe so, yes.
,
Oct 17
Marking as fixed, per comment 4. |
||
►
Sign in to add a comment |
||
Comment 1 by dtapu...@chromium.org
, Sep 11