New issue
Advanced search Search tips

Issue 882835 link

Starred by 1 user
Status: Fixed
Owner:
pdr@chromium.org
Closed: Oct 8
Cc:
rdevlin....@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Unwanted flickering of 'options' overlay is observed for LinkedIn Extension.

Reported by shruti.j...@etouch.net, Sep 11 
Chrome Version : 71.0.3549.0 (Official Build) 09b135be6dd0aee298f10cd511efd6574d2edd7f-refs/branch-heads/3549@{#1} 32/64 bit
OS: Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14)  and Linux(14.04 LTS)

Test URL:https://chrome.google.com/webstore/detail/linkedin-extension/meajfmicibjppdgbjfkpdikfjcflabpk

Steps to reproduce:
1.Launch chrome and add extension.
2.Right click on added extension in omnibox and select 'option'.
3.Observe the option overlay.

Actual Result:Unwanted flickering of 'options' overlay is observed for LinkedIn Extension.
Expected Result: 'Options' overlay should not flicker continuously for LinkedIn Extension.

This is a regression issue, broken in 'M-70' and below is the per-revision info:

Good Build:70.0.3521.0(Revision:582484)
Bad Build:70.0.3522.0(Revision:582755)

You are probably looking for a change made after 582707 (known good), but no later than 582708 (first known bad).
CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/e10dc3ec0cacd865cede77c59255c2bae2358d1f..33cd2bccd7dbd33dfddbe3fb4f4c8a6b1a7e4617

Suspect: https://chromium.googlesource.com/chromium/src/+/33cd2bccd7dbd33dfddbe3fb4f4c8a6b1a7e4617

@Philip : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly refer the attached screen-cast.

Thank You.
Actual_Result.mp4
1.5 MB View Download
Expected_Result.mp4
1.0 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/144eba446c1e9dd6b94389571e53e885c4a0bd8b

commit 144eba446c1e9dd6b94389571e53e885c4a0bd8b
Author: Philip Rogers <pdr@chromium.org>
Date: Wed Oct 03 21:06:04 2018

Add hysteresis to extensions options dialog preferred size logic

The md extension options dialog has an inner frame with the options page
contents. The dialog is sized based on the preferred size of the options
page contents using preferred size change events. The options page
contents's size is also dependent on the dialog size, so resizing the
dialog can result in a preferred size change event which then resizes
the dialog size again. Because the options dialog and the options page
contents are on different threads, this size update logic can infinitely
oscillate between two sizes.

This bug became more prominent with two recent changes:
https://crrev.com/581383 - made preferred size changes synchronous
https://crrev.com/582708 - moved preferred size change events from the
middle of a frame to the end of a frame.

This patch adds a delay between getting the preferred size update and
changing the dialog size, fixing the options dialog size oscillation.
This mimics the asynchronous preferred size updates that were done
before https://crrev.com/581383.

Test: manually tested using 4 custom extension options pages (short
quirksmode, tall quirksmode, short html5, and tall html5).

Bug:  882835 
Change-Id: I97bd61c3137ae851d855637aed75029bce1e5404
Reviewed-on: https://chromium-review.googlesource.com/c/1259040
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596359}
[modify] https://crrev.com/144eba446c1e9dd6b94389571e53e885c4a0bd8b/chrome/browser/resources/md_extensions/options_dialog.js
[modify] https://crrev.com/144eba446c1e9dd6b94389571e53e885c4a0bd8b/chrome/test/data/webui/extensions/options_dialog_test.js

Comment 2 by pdr@chromium.org, Oct 3

Labels: Merge-Request-71
Requesting a merge into M71
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 3

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: We don't branch M71 until 2018-10-11.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by pdr@chromium.org, Oct 3

Cc: rdevlin....@chromium.org
Oops, I misread go/chrome-release. I now think this does not need a merge, as we are very close to release.

This means we will have a regression in M70. Devlin, does that sound okay or do you think I should push to merge this to M70?

Comment 5 by rdevlin....@chromium.org, Oct 3 

Unless we hear more about this issue cropping up, I think releasing in M71 is okay.

Comment 6 by gov...@chromium.org, Oct 8 

M71 is NOT branched yet. Is this merge request for M70?

Comment 7 by pdr@chromium.org, Oct 8

Status: Fixed (was: Assigned)
We will let this regress in M70 and let the fix roll out in M71. I don't think any merges are requested.

Comment 8 by gov...@chromium.org, Oct 8

Labels: -Merge-Review-71
Removing "Merge-Review-71" label per comment #6 & #7. Thank you.
►

Sign in to add a comment