New issue
Advanced search Search tips

Issue 882832 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 12
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: ExtensionWebRequestApiTest.WebRequestTypes

Blocking:
issue 876224



Sign in to add a comment

ExtensionWebRequestApiTest.WebRequestTypes is flaky

Project Member Reported by Findit, Sep 11

Issue description

Components: Platform>Extensions
Owner: kaznacheev@chromium.org
Status: Assigned (was: Untriaged)
Blocking: 876224
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2036d4f64195d38ff3d5fbed3faebdcdc9db5c0f

commit 2036d4f64195d38ff3d5fbed3faebdcdc9db5c0f
Author: Gabriel Charette <gab@chromium.org>
Date: Tue Sep 11 16:47:36 2018

Revert "Update bundled Chrome app icon for MD compliance"

This reverts commit 6e2e384b482bd32c5bc0b037184e9e6311796673.

Reason for revert: Not sure why, but seems a pretty clear culprit for  crbug.com/882832 

Original change's description:
> Update bundled Chrome app icon for MD compliance
> 
> - Update chrome_app manifest to support 32 and 192px icons.
> - Use 192px icon as window icon for Chrome browser.
> - Move all resource handing related to chrome_app under
>   OS_CHROMEOS ifdef.
> 
> Bug:  879618 
> Test: manual
> Change-Id: If3e9fb396424159ea0bf7f2cf61febfd89838b62
> Reviewed-on: https://chromium-review.googlesource.com/1210943
> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589771}

TBR=kaznacheev@chromium.org,oshima@chromium.org,thestig@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  879618 
Change-Id: Idd28ce462ab64d417e4c6137a8ecbc7966975f42
Reviewed-on: https://chromium-review.googlesource.com/1219908
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590348}
[modify] https://crrev.com/2036d4f64195d38ff3d5fbed3faebdcdc9db5c0f/chrome/app/theme/chrome_unscaled_resources.grd
[delete] https://crrev.com/7c4f701b95e9da69e188fadc5790379e0689958d/chrome/app/theme/chromium/chromeos/chrome_app_icon_192.png
[delete] https://crrev.com/7c4f701b95e9da69e188fadc5790379e0689958d/chrome/app/theme/chromium/chromeos/chrome_app_icon_32.png
[modify] https://crrev.com/2036d4f64195d38ff3d5fbed3faebdcdc9db5c0f/chrome/browser/extensions/chrome_component_extension_resource_manager.cc
[modify] https://crrev.com/2036d4f64195d38ff3d5fbed3faebdcdc9db5c0f/chrome/browser/resources/chrome_app/manifest.json
[modify] https://crrev.com/2036d4f64195d38ff3d5fbed3faebdcdc9db5c0f/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/2036d4f64195d38ff3d5fbed3faebdcdc9db5c0f/chrome/browser/ui/views/frame/browser_view.cc
The culprit is reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1219908

If find it very strange that this CL is the real cause, as it was not supposed to change anything on non-ChromeOS builds. However, it is hard to argue with the evidence.

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fb764ab96a88555e11150e9e7ca4c17119b6388

commit 1fb764ab96a88555e11150e9e7ca4c17119b6388
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Wed Sep 12 19:15:22 2018

Re-land "Update bundled Chrome app icon for MD compliance"

This reverts commit 2036d4f64195d38ff3d5fbed3faebdcdc9db5c0f.

The failing test that caused the revert is now disabled
(https://chromium-review.googlesource.com/c/chromium/src/+/1217710)

Bug:  882832 , 879618 
Change-Id: I61b3e805badef2eef322397c5bf3336a482936b3
Reviewed-on: https://chromium-review.googlesource.com/1222506
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590777}
[modify] https://crrev.com/1fb764ab96a88555e11150e9e7ca4c17119b6388/chrome/app/theme/chrome_unscaled_resources.grd
[add] https://crrev.com/1fb764ab96a88555e11150e9e7ca4c17119b6388/chrome/app/theme/chromium/chromeos/chrome_app_icon_192.png
[add] https://crrev.com/1fb764ab96a88555e11150e9e7ca4c17119b6388/chrome/app/theme/chromium/chromeos/chrome_app_icon_32.png
[modify] https://crrev.com/1fb764ab96a88555e11150e9e7ca4c17119b6388/chrome/browser/extensions/chrome_component_extension_resource_manager.cc
[modify] https://crrev.com/1fb764ab96a88555e11150e9e7ca4c17119b6388/chrome/browser/resources/chrome_app/manifest.json
[modify] https://crrev.com/1fb764ab96a88555e11150e9e7ca4c17119b6388/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/1fb764ab96a88555e11150e9e7ca4c17119b6388/chrome/browser/ui/views/frame/browser_view.cc

Status: Fixed (was: Assigned)

Sign in to add a comment