New issue
Advanced search Search tips

Issue 882826 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unable to visually differentiate between NTP page and notification bubble as the border for bubble is removed.

Reported by avsha...@etouch.net, Sep 11

Issue description

Chrome Version : 71.0.3549.0 (Official Build) 09b135be6dd0aee298f10cd511efd6574d2edd7f-refs/branch-heads/3549@{#1} 32/64 bit
OS : Windows (7, 8, 8.1)

Test URL : https://tests.peter.sh/notification-generator/

What steps will reproduce the problem?
1. Launch chrome, navigate to above test URL and click on 'Allow' when it asks for notifications permission.
2. Click on 'Display the notification' button seen on the page (notification bubble appears at bottom)
3. Open NTP and observe the notification bubble.

Actual Result : Unable to visually differentiate between NTP page and notification bubble as the border for bubble is not visible.

Expected Result : Notification bubble should have borders such that it can be visible properly on NTP page.

This is a regression issue broken in ‘M-71’ and below is the 'Chromium bisect' information:
Good Build : 70.0.3538.0 (Revision : 587812)
Bad Build : 71.0.3539.0 (Revision : 588235)

Chromium bisect URL :
https://chromium.googlesource.com/chromium/src/+log/ea29e693c42ef0d31fc621813a97dbf6ad72a285..bd5933732c1acc6b426cebfb8d16d32c7a0fc1b9

Suspect : r587960

Tetsui@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. This issue is not reproducible in Win-10, Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.14, 10.13.6) OS due to different notification bubble UI.
2. Tried to perform 'per-revision' bisect but it always shows "no enough builds available" error message (tried on different machines but still got the same error.)
3. Hence providing suspect through 'Chromium bisect'.

Thank you..!
 
Actual_Result.mp4
932 KB View Download
Expected_Result.mp4
655 KB View Download
Notification_bubble.png
29.1 KB View Download
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2906b96e723e00560f8517e7f8ebdc1b4275bae2

commit 2906b96e723e00560f8517e7f8ebdc1b4275bae2
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Fri Sep 21 03:19:47 2018

Restore notification shadow border on Win7 Aero

According to QA we still need notification border shadow on Win7 Aero.

TEST=manual
BUG= 882826 

Change-Id: Ia69a366188b595ff6e0c61c4b4f3c06a57c70580
Reviewed-on: https://chromium-review.googlesource.com/1233014
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593064}
[modify] https://crrev.com/2906b96e723e00560f8517e7f8ebdc1b4275bae2/ui/message_center/views/message_view.cc

Status: Fixed (was: Started)

Sign in to add a comment