Issue metadata
Sign in to add a comment
|
Regression: Unnecessary keyboard section is seen in ubertray when 'Show input options in shelf' is enabled |
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3538.15/11021.12.0 dev channel Daisy,Kip,Reks OS: Chrome OS What steps will reproduce the problem? (1)Sign-in to user>> Navigate to Chrome://settings/languages (2)Click on Input method and enable 'Show input options in the shelf' toggle button (3)Now, Click on Ubertray and observe unnecessary keyboard section. Actual: Unnecessary keyboard section is seen in ubertray when 'Show input options in shelf' is enabled Expected: When 'Show input options in shelf' is enabled, keyboard section should not be seen in ubertray. This is a Regression issue as same is working fine in M69 NOTE: Issue is also seen in M71 Attaching screencasts for reference...
,
Sep 21
,
Oct 2
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58a957b5daddda1492d9497525eabe34618c0d57 commit 58a957b5daddda1492d9497525eabe34618c0d57 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Oct 05 01:59:33 2018 Unified: Fix condition of showing IME feature pod This CL fixes the condition of IME feature pod button to be shown. It should hide the button when a separate IME tray is shown in Shelf. TEST=manual BUG= 882824 Change-Id: I4907f3cb01facbcbe7e14cd3329c413bb1adce24 Reviewed-on: https://chromium-review.googlesource.com/c/1255753 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#596960} [modify] https://crrev.com/58a957b5daddda1492d9497525eabe34618c0d57/ash/ime/ime_controller.cc [modify] https://crrev.com/58a957b5daddda1492d9497525eabe34618c0d57/ash/ime/ime_controller.h [modify] https://crrev.com/58a957b5daddda1492d9497525eabe34618c0d57/ash/system/ime/ime_feature_pod_controller.cc [modify] https://crrev.com/58a957b5daddda1492d9497525eabe34618c0d57/ash/system/ime/ime_feature_pod_controller.h [modify] https://crrev.com/58a957b5daddda1492d9497525eabe34618c0d57/ash/system/ime/ime_feature_pod_controller_unittest.cc
,
Oct 5
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tetsui@chromium.org
, Sep 12Owner: tetsui@chromium.org