New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 882822 link

Starred by 1 user
Status: Fixed
Owner:
█ tgu...@chromium.org
Last visit > 30 days ago
Closed: Sep 25
Cc:
yyushkina@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ramyan@chromium.org
bklmn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug


Participants' hotlists:
NTP-Birthday-Polish


Sign in to add a comment

[NTP] Tooltip is not displaying for gear icon.

Reported by dchau...@etouch.net, Sep 11 
Chrome Version: 69.0.3497.92 (Official Build) Revision	eb2c6d16bcb960cc5c322243c1771713460c4bcf-refs/branch-heads/3497@{#921} (32/64-bit)
OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTs).

Pre-condition: Enable "Enable using the Google local NTP" and "New Tab Page Background Selection" flags from chrome://flags.

What steps will reproduce the problem?
1. Launch Chrome and navigate to NTP.
2. Hover the mouse pointer on gear icon and observe.

Actual: Tool-tip doesn't appear for gear icon.
Expected: Tool-tip should appear for gear icon.

This is a non-regression issue, seen from M-68 series as gear icon is introduced from build #68.0.3433.0

NOTE: This issue is also reproducible on Stable, Beta #69.0.3497.81, Dev #70.0.3538.9 & Canary #71.0.3549.0

Kindly review the attached screen-cast for reference.

Thank you.
Actual behavior.mp4
380 KB View Download

Comment 1 by ramyan@chromium.org, Sep 11

Cc: bklmn@chromium.org
edit-bg-gear has an aria-label but not a title (for the tooltip).

IDS_NTP_CUSTOM_BG_CUSTOMIZE_BACKGROUND is defined as "The title for the tooltip for background customization. (On the New Tab Page)" ... but it's currently used as the menu title (only).

Yana: does it (still) make sense to use "Customize this page" as the tooltip here? If so, we could reuse this string & update the grd description.

Comment 2 by twelling...@chromium.org, Sep 11

Labels: zine-triaged

Comment 3 by yyushkina@chromium.org, Sep 11

Cc: yyushkina@chromium.org
Owner: ramyan@chromium.org
It does! Let's re-use "Customize this page" as you suggest.

Comment 4 by tgu...@chromium.org, Sep 20

Owner: tgu...@chromium.org

Comment 5 by tgu...@chromium.org, Sep 25

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efc1b61ec1db1a01cc7aa29474c51ed9daf86b3b

commit efc1b61ec1db1a01cc7aa29474c51ed9daf86b3b
Author: Tanya Gupta <tgupta@chromium.org>
Date: Tue Sep 25 17:52:01 2018

Added a tooltip for the change background gear head on the New Tab Page


R=ramyan@chromium.org

Bug:  882822 
Change-Id: I1a70d25d39a927d0a07a2a77420f0b696513c788
Reviewed-on: https://chromium-review.googlesource.com/1241795
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593998}
[modify] https://crrev.com/efc1b61ec1db1a01cc7aa29474c51ed9daf86b3b/chrome/app/generated_resources.grd
[modify] https://crrev.com/efc1b61ec1db1a01cc7aa29474c51ed9daf86b3b/chrome/browser/resources/local_ntp/custom_backgrounds.js

Comment 7 by tgu...@chromium.org, Sep 25

Status: Fixed (was: Started)

Comment 8 by dchau...@etouch.net, Sep 26

Labels: TE-Verified-M71 TE-Verified-71.0.3562.0
Updated:
Re-tested this issue on Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTS) machines using latest Canary build #71.0.3562.0 and the issue is fixed i.e. tool-tip appears for gear icon. Hence adding TE-Verified labels. 

Kindly review an attached screen-cast for reference.

Thank you..!
Fixed behavior.mp4
588 KB View Download

Comment 9 by ramyan@chromium.org, Oct 18

Labels: AddToRemoteNTP
►

Sign in to add a comment