' ! ' sign in notification message 'Can't create shortcut' is seen misplaced under RTL on NTP.
Reported by
sanyam.g...@etouch.net,
Sep 11
|
||||
Issue descriptionChrome Version:71.0.3549.0 (Official Build) Revision 09b135be6dd0aee298f10cd511efd6574d2edd7f-refs/branch-heads/3549@{#1} (32/64-bit) OS: Windows (7, 8, 8.1, 10),Mac(10.12.6, 10.13.1, 10.13.6, 10.14) & Linux(14.04 LTS) OS. Pre-condition: Enable 'Enable using the Google local NTP', 'New Tab Page Custom Links' and 'set Force UI direction' to 'Right-to-Left' under chrome://flags. What steps will reproduce the problem? 1. Launch Chrome, navigate to NTP and click on 'Add Shortcut' to open the overlay. 2. Enter the text in 'Name' & 'URL' text-fields and click on 'Done' button to create shortcut.. 3. Again open the 'Add Shortcut' overlay and enter the 'Same' Name and URL as entered in step 2. 4. Click on done button and observe. Actual Result : '!' sign in notification message 'Can't create shortcut' is seen misplaced under RTL. Expected Result: Notification message should be seen properly even after RTL. This is Non-Regression issue seen from ‘M-70’ as 'Can't create shortcut' option has been introduced from build #70.0.3536.0 Kindly review the attached screen-cast for reference. Note: Issue is also reproducible after changing chrome language to any RTL language e.g: Arabic in Windows OS. Thank you..!!
,
Sep 11
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15e9c7e426b541dd76535ac9f4f9651ef7af985d commit 15e9c7e426b541dd76535ac9f4f9651ef7af985d Author: kristipark <kristipark@chromium.org> Date: Wed Sep 12 23:25:27 2018 [NTP] Fix RTL for custom link error notifications Before: https://screenshot.googleplex.com/kdYOAbqHTe4.png After: https://screenshot.googleplex.com/CE4vDHwCPET.png Bug: 882814 Change-Id: I7464a188c521e309dc8bc0f9346378c85f1ac33c Reviewed-on: https://chromium-review.googlesource.com/1222312 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#590856} [modify] https://crrev.com/15e9c7e426b541dd76535ac9f4f9651ef7af985d/chrome/browser/resources/local_ntp/local_ntp.css
,
Sep 13
,
Sep 25
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ramyan@chromium.org
, Sep 11Owner: kristip...@chromium.org