New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 882808 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Buried. Ping if important.
Closed: Sep 11
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[Missing Test]:Third party cookie blocking broken in some cases

Project Member Reported by jmukthavaram@chromium.org, Sep 11

Issue description

Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
----
https://chromium.googlesource.com/chromium/src.git/+/32530766f2dde549e48f3423a22a13df5a1e7dff

Ref Bug: 
---------
https://bugs.chromium.org/p/chromium/issues/detail?id=881715

Thank you.
 
Weren't these already added in  https://crrev.com/dd5cc6378d56b34d64ee3bcabddb642246bc96d3/chrome/browser/net/cookie_policy_browsertest.cc, which was already landed in linked to in that previous bug?
Status: Fixed (was: Assigned)
Yeah. Those were the tests for the patch which got merged back. I landed them separately to ensure that merging would be as easy as possible.

Thanks for following up! It's good to make sure we have tests!

Sign in to add a comment