Chrome Version:70.0.3538.15/11021.12.0 dev channel Daisy,Kip,Reks
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user >> launch chrome >> goto chrome://settings/smbShares
(2)Click on Add File Share >> click on Add button (which is enabled by default)and observe chrome crashes

Actual: Chrome crashes on clicking Add button in Add File Share
Expected: Chrome shouldn't get crash

Raising this as a Non-Regression issue seen from M-70 as it is a new feature

Attached the screencast for reference..

Crash Ids:
----------
9e332ea779d1df3e
87cb8386082ef7e0
0b3dcc207e5e8698

Stack Trace:
------------

Thread 0 (id: 0x3f6) CRASHED [SIGTRAP @ 0x00000000 ] MAGIC SIGNATURE THREAD
Stack Quality99%Show frame trust levels
0xb3a6461c	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/ui/webui/settings/chromeos/smb_handler.cc:57 )	chromeos::settings::SmbHandler::HandleSmbMount(base::ListValue const*)
0xb0bda88b	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/ipc/ipc_message_templates.h:64 )	bool IPC::MessageT<FrameHostMsg_WebUISend_Meta, std::__1::tuple<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, base::ListValue>, void>::Dispatch<content::WebUIImpl, content::WebUIImpl, content::RenderFrameHost, void (content::WebUIImpl::*)(content::RenderFrameHost*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, base::ListValue const&)>(IPC::Message const*, content::WebUIImpl*, content::WebUIImpl*, content::RenderFrameHost*, void (content::WebUIImpl::*)(content::RenderFrameHost*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, base::ListValue const&))
0xafd6d4d9	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/content/browser/webui/web_ui_impl.cc:102 )	content::WebContentsImpl::OnMessageReceived(content::RenderFrameHostImpl*, IPC::Message const&)
0xb0966815	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/content/browser/frame_host/render_frame_host_impl.cc:1045 )	content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const&)
0xb0ab9a29	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/content/browser/renderer_host/render_process_host_impl.cc:3310 )	content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&)
0xb20f85f3	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/ipc/ipc_channel_proxy.cc:320 )	IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&)
0xaff00671	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/base/callback.h:99 )	base::MessageLoop::DoWork()
0xaff0b065	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/base/message_loop/message_pump_libevent.cc:210 )	base::MessagePumpLibevent::Run(base::MessagePump::Delegate*)
0xb1cd2e09	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/base/run_loop.cc:102 )	predictors::PredictorTableBase::PredictorTableBase(scoped_refptr<base::SequencedTaskRunner>)
0xb1a19c15	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/chrome_browser_main.cc:2078 )	ChromeBrowserMainParts::MainMessageLoopRun(int*)
0xb084b757	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/content/browser/browser_main_loop.cc:1039 )	content::BrowserMainLoop::RunMainMessageLoopParts()
0xb084dfab	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/content/browser/browser_main_runner_impl.cc:161 )	content::BrowserMainRunnerImpl::Run()
0xb0845f3b	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/content/browser/browser_main.cc:47 )	content::BrowserMain(content::MainFunctionParams const&)
0xb1a0c6a3	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/content/app/content_main_runner_impl.cc:537 )	content::ContentMainRunnerImpl::Run(bool)
0xb1a118af	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/services/service_manager/embedder/main.cc:472 )	service_manager::Main(service_manager::MainParams const&)
0xb1a0b843	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/content/app/content_main.cc:19 )	content::ContentMain(content::ContentMainParams const&)
0xaffbdc1f	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/chrome/app/chrome_main.cc:102 )	ChromeMain
0xaf79189f	(libc-2.23.so -libc-start.c:289 )	__libc_start_main
0xaffb27e3	(chrome + 0x002ad7e3 )	_start
0xb5b1d91f	(chrome -elf-init.c:87 )	__libc_csu_init
0xbeeac713		


Link to the list of builds:
---------------------------

https://crash.corp.google.com/browse?q=product_name%3D%27Chrome_ChromeOS%27++AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27chromeos%3A%3Asettings%3A%3ASmbHandler%3A%3AHandleSmbMount%27


Issue seems to be related to https://chromium-review.googlesource.com/c/chromium/src/+/1194790

@Bailey Berro:Could you please take a look into this issue and confirm whether it is related to your change,if not please help us in reassigning to its right owner.
Thank you!
 

 

Deleted: Crash.mp4 6.3 MB

	Crash.mp4 6.3 MB View Download