AEC3: Bug in the transition between main and shadow filter output |
||
Issue descriptionThere is a bug when transitioning from using the main filter output to shadow filter output and vice versa. The bug causes the new signal to be used without proper transition, resulting in audio glitches.
,
Sep 11
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/ddb82a6b5f97fb141a097f70e9b653c6d8256eaa commit ddb82a6b5f97fb141a097f70e9b653c6d8256eaa Author: Gustaf Ullberg <gustaf@webrtc.org> Date: Tue Sep 11 11:59:12 2018 AEC3: Fix filter output transition when input and output is the same array This CL fixes a bug in the filter output transition when the 'from' input points to the same array as the output. It also includes a slight improvement to the transition by starting one sample earlier than previously. Bug: webrtc:9741 , chromium:882789 Change-Id: Ifd5f16c1ac88a74d93499e7f4b4c0e5cb3e4976f Reviewed-on: https://webrtc-review.googlesource.com/99540 Reviewed-by: Per Ã…hgren <peah@webrtc.org> Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24683} [modify] https://crrev.com/ddb82a6b5f97fb141a097f70e9b653c6d8256eaa/modules/audio_processing/aec3/echo_remover.cc
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d70333366eb32aadb4d75cddc88fa7d76bfc3ac5 commit d70333366eb32aadb4d75cddc88fa7d76bfc3ac5 Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Sep 11 14:58:41 2018 Roll src/third_party/webrtc 3d50a31aad31..7cd0e15faf17 (8 commits) https://webrtc.googlesource.com/src.git/+log/3d50a31aad31..7cd0e15faf17 git log 3d50a31aad31..7cd0e15faf17 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 stefan@webrtc.org Add nisse@, ilnik@ and sprang@ as OWNERS to media/. 2018-09-11 gustaf@webrtc.org AEC3: Fix filter output transition when input and output is the same array 2018-09-11 mbonadei@webrtc.org Fix no_global_constructors in remote_bitrate_estimator. 2018-09-11 magjed@webrtc.org Android: Send original texture width/height in TextureBufferImpl 2018-09-11 nisse@webrtc.org Delete always true member voe::Channel::pacing_enabled_ 2018-09-11 sprang@webrtc.org Don't signal updated bitrate allocation on encoder paused 2018-09-11 sprang@webrtc.org Updated min bitrate for high-quality screenshare simulcast stream 2018-09-11 gustaf@webrtc.org AEC3: Bugfix in filter output transition Created with: gclient setdep -r src/third_party/webrtc@7cd0e15faf17 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:882789,chromium:None,chromium:882789 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icaca70c95614fddaf43c75b10737aa2f651594ab Reviewed-on: https://chromium-review.googlesource.com/1219413 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590307} [modify] https://crrev.com/d70333366eb32aadb4d75cddc88fa7d76bfc3ac5/DEPS
,
Sep 12
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Sep 11