New issue
Advanced search Search tips

Issue 882785 link

Starred by 1 user
Status: Verified
Owner:
djean@chromium.org
Closed: Sep 14
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Apply bookmark search UX to history

Project Member Reported by djean@chromium.org, Sep 11 
Chrome Version: (copy from chrome://version)
OS: iOS

What steps will reproduce the problem?
(1) History 
(2) Focus search field

What is the expected result?
A scrim should appear while search bar is focused and input field is empty.

What happens instead?
No scrim

Comment 1 by thegreenfrog@chromium.org, Sep 13

Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38b7239161f25697a512ebb7ae7eda0a2afdae9a

commit 38b7239161f25697a512ebb7ae7eda0a2afdae9a
Author: David Jean <djean@google.com>
Date: Fri Sep 14 13:33:15 2018

[ios] Update History Search UI to match Bookmarks

Show scrim when search controller is active but no query has been entered (see iOS Contacts app).
Allow cancelling by tapping the scrim.
Dedupped some constants as discussed in previous CLs.
Updated history search bar centering code to restore previous value on exit.

Bug:  882785 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id4ba6dc704c70ce44334431f95c66c9ed133b3a0
Reviewed-on: https://chromium-review.googlesource.com/1219002
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591335}
[modify] https://crrev.com/38b7239161f25697a512ebb7ae7eda0a2afdae9a/ios/chrome/browser/ui/bookmarks/BUILD.gn
[modify] https://crrev.com/38b7239161f25697a512ebb7ae7eda0a2afdae9a/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/38b7239161f25697a512ebb7ae7eda0a2afdae9a/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
[modify] https://crrev.com/38b7239161f25697a512ebb7ae7eda0a2afdae9a/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/38b7239161f25697a512ebb7ae7eda0a2afdae9a/ios/chrome/browser/ui/history/history_table_view_controller.mm
[modify] https://crrev.com/38b7239161f25697a512ebb7ae7eda0a2afdae9a/ios/chrome/browser/ui/history/history_ui_constants.h
[modify] https://crrev.com/38b7239161f25697a512ebb7ae7eda0a2afdae9a/ios/chrome/browser/ui/history/history_ui_constants.mm
[modify] https://crrev.com/38b7239161f25697a512ebb7ae7eda0a2afdae9a/ios/chrome/browser/ui/history/history_ui_egtest.mm
[modify] https://crrev.com/38b7239161f25697a512ebb7ae7eda0a2afdae9a/ios/chrome/browser/ui/table_view/table_view_navigation_controller_constants.h
[modify] https://crrev.com/38b7239161f25697a512ebb7ae7eda0a2afdae9a/ios/chrome/browser/ui/table_view/table_view_navigation_controller_constants.mm

Comment 3 by djean@chromium.org, Sep 14

Status: Fixed (was: Assigned)

Comment 4 by yangulo@chromium.org, Sep 18

Status: Verified (was: Fixed)
Issue verified 
Version: Chrome Canary 71.0.3555.0
Device: iPhone 8
iOS: 12.0

Scrim shows up
https://drive.google.com/open?id=1L5o86V7Q8ttKCkj7EcPRhgXAigBhI0UF
►

Sign in to add a comment