New issue
Advanced search Search tips

Issue 882782 link

Starred by 1 user
Status: Fixed
Owner:
timloh@chromium.org
Closed: Sep 26
Cc:
timzheng@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Chrome crashes when switching profiles if Terminal launch is queued

Project Member Reported by timloh@chromium.org, Sep 11 
1. Log in to profiles A, then B
2. On profile A, launch Terminal
3. Immediately switch (ctrl-shift-.) to B and then back to A (before the container is ready and the terminal opens)
4. Crash!

I think this is as we create a Browser beforehand, but when switching back we try to add the Browser to the shelf and this fails.

#3  0x0000575d68264c18 in chrome::FindBrowserWithWebContents(content::WebContents const*) () at ../../chrome/browser/ui/browser_finder.cc:211
#4  0x0000575d68489963 in (anonymous namespace)::GetExtensionForTab(Profile*, content::WebContents*) () at ../../chrome/browser/ui/ash/launcher/launcher_controller_helper.cc:55
#5  0x0000575d684895d2 in LauncherControllerHelper::GetAppID(content::WebContents*) () at ../../chrome/browser/ui/ash/launcher/launcher_controller_helper.cc:156
#6  0x0000575d684706d2 in ChromeLauncherController::UpdateAppState(content::WebContents*, bool) () at ../../chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:456
#7  0x0000575d6848f688 in MultiProfileBrowserStatusMonitor::ConnectV1AppToLauncher(Browser*) () at ../../chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc:94
#8  0x0000575d6848f217 in MultiProfileBrowserStatusMonitor::ActiveUserChanged(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ()
    at ../../chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc:35
#9  0x0000575d68472704 in ChromeLauncherController::ActiveUserChanged(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ()

Comment 1 by timloh@chromium.org, Sep 13

Owner: timloh@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7340785c74d3d7ea74b557244c46270ebd69b67

commit c7340785c74d3d7ea74b557244c46270ebd69b67
Author: Timothy Loh <timloh@chromium.org>
Date: Tue Sep 25 00:05:49 2018

Fix crashes when switching profiles with incomplete terminal launch

This CL fixes a crash that occurs when switching to a profile with an
incomplete Crostini terminal launch. While the BrowserStatusMonitor was
already excluding the Crostini terminal from getting a shelf item, it
was still tracking the Browsers, and ended up trying to add these
to the shelf on profile switching.

Bug:  882782 
Change-Id: I7e406b1481a9ad5adb372335ebab421f1742acc1
Reviewed-on: https://chromium-review.googlesource.com/1235775
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593759}
[modify] https://crrev.com/c7340785c74d3d7ea74b557244c46270ebd69b67/chrome/browser/ui/ash/launcher/browser_status_monitor.cc

Comment 3 by timloh@chromium.org, Sep 26

Status: Fixed (was: Assigned)
►

Sign in to add a comment